Created attachment 30834 [details] [review]
First version of patch that adds OT support to Hebrew module.

Mostly looks good to me.... what do you think needs improvement in:

+  /* Trigger use of heuristics if there is no GPOS table in font!
+   * Is there a better way to do this?
+   */
+  if (!pango_ot_info_find_script (info, PANGO_OT_TABLE_GPOS,
+				  hebr_tag, &script_index))
+    return NULL;

Is the concern that we are going to hit this every time for a font
without a GPOS table for hebr?

He probably means that if there are no GPOS tables in the font to use for vowel
positioning, then to fall back to the old heuristic that guesses at vowel
positioning.

Hi Owen,

I was not sure if ruleset==NULL is an appropriate way of signalling that there
is no GPOS table in the font. Perhaps it would be better to query the ruleset.
In any case, if its fine with you, it's fine with me.

If you have some idea for avoiding querying the info about a GPOS table every
time, then please describe it to me or just modify the patch before applying.

Btw, I have got several very emails from people in the biblical research
community, that are very excited about this patch. 8-)

Created attachment 30943 [details] [review]
Second version of Hebrew OpenType patch.