GNOME Bugzilla – Bug 150018
[PATCH] gphoto integration
Last modified: 2005-02-17 12:01:52 UTC
This bug is for a patch to support using libgphoto2 to copy and import files from digital cameras. The majority of the work is actually the bindings for libgphoto2 which can be found at the libgphoto2# page at Novell Forge ( http://forge.novell.com/modules/xfmod/project/?libgphoto2sharp ). This currently works for me with everything except attaching a tag on import. Testing, suggestions, etc, would be appreciated. The patch is a series of files because I can only get a diff for the files already in cvs. The needed files are: - gphoto-integration.patch - src/CameraFileSelectionDialog.cs - src/CameraSelectionDialog.cs - src/GPhotoCamera.cs I believe the patch can go into cvs now once it has been looked over by somebody, it should be ok except for a bit of missing error checking.
Created attachment 30496 [details] [review] Patch for files already in cvs.
Created attachment 30497 [details] Another piece of the patch, specifically the selection dialog for which files to copy.
Created attachment 30498 [details] Yet another piece of the patch, specifically a dialog for selecting which camera to copy files from.
Created attachment 30499 [details] The final piece of the patch, specifically the wrapper around the libgphoto2# bindings.
I'm about to add a new patch which invalidates a bunch of the older files. This patch fixes a few things, adds features, simplifies by using the already present progress dialog implementation. -adds a file (TagSelectionDialog) along with section in glade file to deal with selecting the tag. It's essentially just the tag selection widget stuck into a dialog. -actually uses that selection properly, and can properly handle multiple tags/photos -alters ImportCommand to allow me to keep track of the photos that have been imported to make it possible to do the above -skips camera selection dialog if only one camera is found -uses the current user's home directory by default, but does it in a bad way, by getting the environment variable because the appropriate glib function doesn't seem to be bound Aside from UI changes, I am happy with the code and it should be pretty stable now, probably ready to commit unless some architectural changes are needed.
Created attachment 30576 [details] [review] New patch for files already in cvs.
Created attachment 30577 [details] New CameraFileSelectionDialog.cs
Created attachment 30578 [details] New CameraSelectionDialog.cs
Created attachment 30579 [details] New GPhotoCamera.cs
Created attachment 30580 [details] TagSelectionDialog.cs New file which supports a new dialog in f-spot.glade that simply uses the TagSelectionWidget to allow the user which tags to apply to the newly imported files.
Does this still apply? I'd love to see it go in...
Unfortunately, no, it doesn't still apply. Last I checked it came close to applying cleanly, maybe 2 chuncks failed, and there were some build issues to work out because some stuff has changed. I don't have time right now to fix this up, but anybody remotely familiar with the f-spot code could probably fix it up pretty quickly. If nobody gets around to it I might find time sometime next week to bring it up to date.
Created attachment 36394 [details] [review] updated patch This is just a quick refresh of the patch to get it building with the trunk again. It doesn't actually work to import at the moment and I disabled the tag setting to get things building but I'll try to spend some time updating things properly soon. Also note that libgphoto2-sharp doesn't install the assembly in the gac so you'll have to set MONO_PATH appropriately to test this out.
The patch has been integrated and significantly changed. For now the libgphoto2 bindgings have been integrated directly into f-spot to keep the build simpler but they can be split back out at any time. Ewen when you find some time let me know what you'd liske to do.