After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 149356 - impossible to add folders to archive with new file selector
impossible to add folders to archive with new file selector
Status: RESOLVED OBSOLETE
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2004-08-05 00:19 UTC by Tino Meinen
Modified: 2006-10-21 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tino Meinen 2004-08-05 00:19:42 UTC
start file-roller
click New in the toolbar
type a name in the Name field
click the button New => a new archive is created
click Add in the Toolbar => new file-selector shows up
click a folder in the new file-selector
click Add in the new file-selector (the Add button in the lower richt corner not
the one on the middle left)

RESULT:
The file-selector shows the contents of the clicked folder

Expected:
The file-selector should have closed, and file-roller should have added the
clicked folder to the archive


As a side note:
The file-selector shows two buttons with "Add"  (each containing a different
icon though) the one on the middle left adds a folder to the bookmarks/favorites
folder, the other one should add a folder to the archive (which it doens't at he
moment).
The two 'add' buttons in the file-selector dialog are a bit confusing. The
difference now only shows in the icon, the user doesn't know what's going to be
added to what.
Ideally the wording should be chosen differently for one of the buttons.
(add to archive)
Comment 1 Allison Karlitskaya (desrt) 2004-08-05 18:48:44 UTC
I have followed your instructions and am unable to reproduce with 2.7.3.  What
version are you using?
Comment 2 Tino Meinen 2004-08-05 21:28:46 UTC
Damn, that's really stupid of me, I was using 2.6.0 Fedora Core 2 version.
The file-rollers shipped with Mandrake 10.1 beta 1 had the same error.

Glad to hear this is now aparently fixed in 2.7.3

This bug can then be closed as fixed.
I should have to look at the naming of the 'add' buttons though to see if that's
improved in 2.7.3 as well though.

Comment 3 Reinout van Schouwen 2004-08-06 09:48:20 UTC
I can reproduce the bug with File-roller 2.7.3. Please reopen.
Comment 4 Tino Meinen 2004-08-21 05:46:56 UTC
I finally built file-roller myself and I can still reproduce this with the
latest gnome CVS: fileroller 2.7.4  
gtk2 cvs version

Reopening
Comment 5 Paolo Bacchilega 2004-08-21 06:29:30 UTC
to add a folder you have to use Edit->Add a Folder
Comment 6 Tino Meinen 2004-08-21 14:53:36 UTC
Paolo, this doesn't work either:
I tried it with Edit->Add a folder as well:

As soon as you select a folder and click 'Add' in the new file-selector, the
folder gets added to the path in the file-selector instead of being added to the
archive in file-roller.
Comment 7 Sebastien Bacher 2004-09-18 14:40:33 UTC
Does work with 2.8.0, when you click on add it enters in the directory instead
of adding it.
Comment 8 Tino Meinen 2004-10-03 10:46:02 UTC
Ok, Sebastien, your wording is a bit confusing to me. When "you click on add it
enters in the directory instead of adding it" seems to me to imply that it in
fact does NOT work correctly.
So i guess that's a confirmation.

In fact I wonder how Ryan Lortie in comment #1 could have ever made this work.

More information on the cause of this bug is I found in:
http://bugzilla.gnome.org/show_bug.cgi?id=136294

perhaps for a possible workaround
http://bugzilla.ximian.com/show_bug.cgi?id=64974

There are apparently two different modes for the fileselector in gtk2.
One is Directory mode, and the other is File mode.
In File mode, clicking on directories will show the contents of the directory
instead of adding it. And that is what's happening here.
Comment 9 Sebastien Bacher 2004-10-03 10:58:33 UTC
Oups, yes .. that what supposed to be a "Doesn't work", not a "Does work", sorry
for the confusion
Comment 10 Sebastien Bacher 2004-10-17 10:59:25 UTC
this was a gtk+ bug fixed in 2.4.11:

Overview of Changes from GTK+ 2.4.10 to GTK+ 2.4.11
===================================================
* GtkFileChooser
...
 - Make SELECT_FOLDER mode work [Matthias]
Comment 11 Tino Meinen 2005-09-26 02:37:17 UTC
This bug is still present in version 2.12 of file-roller: Pressing add on a
folder in the file-selector still does not add the folder to the archive, but
instead shows the contents of the folder in the file-selector.

The only way to add a folder to an archive is to drag a folder from the
file-selecor to the content-area of the file-selector.
Comment 12 Paolo Bacchilega 2006-10-21 17:51:26 UTC
adding folders works for me in file-roller 2.17.1, closing...