After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 149268 - http plugin crashes if you attempt to open "http:" or similar
http plugin crashes if you attempt to open "http:" or similar
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Module: http
2.7.x
Other Linux
: High major
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2004-08-04 10:04 UTC by Allison Karlitskaya (desrt)
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the consistent patch (699 bytes, patch)
2004-08-08 04:22 UTC, Allison Karlitskaya (desrt) 		none Details | Review
the patch that keeps DEBUG_HTTP_FUNC if you like it (548 bytes, patch)
2004-08-08 04:23 UTC, Allison Karlitskaya (desrt) 		none Details | Review

Description Allison Karlitskaya (desrt) 2004-08-04 10:04:23 UTC 
This one is pretty straight-forward.  At a shell prompt, just type "eog http:".

Backtrace was generated from '/usr/bin/eog'

(no debugging symbols found)...Using host libthread_db library
"/lib/libthread_db.so.1".
(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
0x406709d8 in waitpid () from /lib/libpthread.so.0

+ Trace 49089

  • #0 waitpid
    from /lib/libpthread.so.0
  • #1 __JCR_LIST__
    from /usr/lib/libgnomeui-2.so.0
  • #2 libgnomeui_segv_handle
    at gnome-ui-init.c line 741
  • #3 __pthread_clock_settime
    from /lib/libpthread.so.0
  • #4 <signal handler called>
  • #5 gnome_vfs_uri_get_toplevel
    from /usr/lib/libgnomevfs-2.so.0
  • #6 gnome_vfs_uri_get_host_name
    from /usr/lib/libgnomevfs-2.so.0
  • #7 ??
    from /usr/lib/gnome-vfs-2.0/modules/libhttp.so
  • #8 ??
  • #9 ??
    from /usr/lib/gnome-vfs-2.0/modules/libhttp.so
  • #10 ??
  • #11 ??
  • #12 ??
  • #13 ??
    from /usr/lib/libglib-2.0.so.0
  • #14 ??
  • #15 g_hash_table_size
    from /usr/lib/libglib-2.0.so.0 

Setting as major/high because it's a crash bug.
Comment 1 Christian Kellner 2004-08-04 14:28:14 UTC 
I managed to reproduce the bug here and I'll have a look at this. Thanks.
Comment 2 Allison Karlitskaya (desrt) 2004-08-08 04:21:30 UTC 
do_get_file_info in http-neon-method.c:

        DEBUG_HTTP_FUNC (1);

        result = http_context_open (uri, &hctx);

        if (result == GNOME_VFS_OK)
                result = http_get_file_info (hctx, file_info, NULL);

        http_context_free (hctx);

        DEBUG_HTTP_FUNC (0);

ie: context is free'd even if allocation fails.


I've cooked two patches.  The first patch corrects this function in a method
that's consistent with all the other vfs functions in the module.

The second patch corrects the function while preserving the weird
DEBUG_HTTP_FUNC business.  (only use this one if you like DEBUG_HTTP_FUNC)

Sorry for not making ChangeLog updates.  I don't have access to the CVS
ChangeLog so my patch would probably reject anyway.
Comment 3 Allison Karlitskaya (desrt) 2004-08-08 04:22:25 UTC 
Created attachment 30319 [details] [review]
the consistent patch
Comment 4 Allison Karlitskaya (desrt) 2004-08-08 04:23:00 UTC 
Created attachment 30320 [details] [review]
the patch that keeps DEBUG_HTTP_FUNC if you like it
Comment 5 Christian Kellner 2004-08-08 08:59:49 UTC 
Nice catch again, thanks! Commited to cvs HEAD. (I would include you real name
in the ChangeLog entries if I had it :)