After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 148986 - [lame] bug in negotiation
[lame] bug in negotiation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal blocker
: 0.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-08-01 11:45 UTC by Zaheer Abbas Merali
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix negotiation (1.24 KB, patch)
2004-08-01 11:46 UTC, Zaheer Abbas Merali 		none Details | Review
test to reproduce (993 bytes, text/x-csrc)
2004-08-01 11:57 UTC, Benjamin Otte (Company) 		  Details
add link function to lame's srcpad (2.26 KB, patch)
2004-08-01 12:31 UTC, Benjamin Otte (Company) 		none Details | Review

Description Zaheer Abbas Merali 2004-08-01 11:45:37 UTC 
Hard to reproduce, I can reproduce in acast.

The symptom is that the warning: ***: pushing data on non-negotiated pad
wcas2:src, not allowed. appears
Comment 1 Zaheer Abbas Merali 2004-08-01 11:46:51 UTC 
Created attachment 30130 [details] [review]
patch to fix negotiation

Please review
Comment 2 Benjamin Otte (Company) 2004-08-01 11:56:29 UTC 
The patch is wrong, lame is missing a linkfunction for the srcpad.
Comment 3 Benjamin Otte (Company) 2004-08-01 11:57:37 UTC 
Created attachment 30131 [details]
test to reproduce
Comment 4 Benjamin Otte (Company) 2004-08-01 12:31:26 UTC 
Created attachment 30132 [details] [review]
add link function to lame's srcpad
Comment 5 Benjamin Otte (Company) 2004-08-01 12:32:37 UTC 
I'm marking this as blocker, so it gets reviewed for inclusion in the 0.8.3
release as its maintainer has expressed a high interest in inclusion of this patch.
Comment 6 Zaheer Abbas Merali 2004-08-01 13:11:07 UTC 
Thanks, I can confirm that your patch does indeed fix the problem I had in acast.
Comment 7 Thomas Vander Stichele 2004-08-02 09:20:34 UTC 
commited, thanks
Comment 8 Martin Eikermann 2004-08-02 09:50:25 UTC 
Hi,

just to let u know there's a small bug in the patch:

+/* we don't do channel conversion */
+  channelcaps = gst_caps_new_simple ("audio/x-raw-int", "chnnels", G_TYPE_INT, 
+      lame->num_channels, NULL);

should read

+/* we don't do channel conversion */
+  channelcaps = gst_caps_new_simple ("audio/x-raw-int", "channels", G_TYPE_INT, 
+      lame->num_channels, NULL);

shouldn't it?
Comment 9 Thomas Vander Stichele 2004-08-02 11:39:09 UTC 
yep, done