GNOME Bugzilla – Bug 148895
Theme Manager Fails to Install .tgz files correctly
Last modified: 2004-12-22 21:47:04 UTC
I've noticed a number of themes packaged as .tgz (rather than .tar.gz) files. If a .tgz file is selected in the theme install dialog, it is moved to the ~/.themes directory but not unpacked. The process fails silently. The attached patch unpacks and correctly installs these files.
Created attachment 30096 [details] [review] Patch to install themes packaged as .tgz files
Created attachment 30098 [details] [review] Improved patch - present an error dialog if the theme is not in one of the expected formats.
Created attachment 30099 [details] [review] Further improvement: remove the unusable file from ~/.themes after showing the dialog.
There are a rewrite of the install procedure in way. See bug #102216. Maybe you can incorporte your changes after the commit of that bug.
The patch works fine here. I think that "This file is not a valid theme" should be changed with "This file is not in a supported format" or something like that since the the content of the archive is not verified. Even if this part is beeing rewritten in #102216 it could be nice to commit this first patch now. Permission to commit it to HEAD (no gnome-2-8 since there is a new string) ?
Comment on attachment 30099 [details] [review] Further improvement: remove the unusable file from ~/.themes after showing the dialog. A nice addition. Get it into head please.
Committed, thanks.