GNOME Bugzilla – Bug 148586
Missing languages in Gnome-Spell
Last modified: 2006-02-10 15:37:55 UTC
When looking at available spellcheckers the following are not displayed even if aspell checkers are availabe: Afrikaans, English (South African), Northern Sotho, Zulu
Created attachment 29944 [details] [review] Missing South African languages This patches the dictionary.c file for gnome-spell
Thanks for the bug report & patch. However, this application does not track its bugs in the GNOME bugzilla. Please report the bug to the application authors at: http://bugzilla.ximian.com Thanks
Bug resumbitted to Ximian buzilla http://bugzilla.ximian.com/show_bug.cgi?id=62271
If i am not mistaken Evolution is now developed in GNOME CVS. Thus I assume Gnome-spell is also developed here. I submitted to the ximian bugzilla database and nothing has happened. So I'm requesting this to be reopened. The patch should still apply as nothing has changed on this file.
Evolution was always in gnome cvs, just not its bugs. Those where moved a while ago. But gnome-spell is still at bugzilla.ximian.com. Don't remember why gnome-spell wasn't moved, probably forgotten. I'll ask; leaving open for now.
Created attachment 55806 [details] [review] patch to add "Croatian" langage to the list for gnome-spell Hi! Here is the patch to add "Croatian" to the list of supported languages in gnome-spell. The file patched is ../gnome-spell/dictionary.c. Here it works with: aspell-hr-0.51.0 & aspell-0.50.5-r4 on amd64 Gentoo. Sincerely, Gour
gour: i've attached a general patch adding additional languages supported by aspell according to http://aspell.sourceforge.net/man-html/Supported.html to http://bugzilla.ximian.com/show_bug.cgi?id=62271 , so your one's obsolete. dwayne: we can't add support for south african languages that we do not have an aspell dictionary for, so i'm setting your patch to "rejected". feel free to reset or to poke me if you have got an idea, i'd really appreciate it to have support for as many languages as possible. xhosa would also be cool. :-/
andre: I don't think that's the right solutions. Please understand that the dealy in not having aspell spell checkers has more do with the fact that Evolution couldn't even use them, not the fact that we can't build them. So we wanted this patch solved first. Now we seem to have had that scuttled also. Considering how long its taken to have anyone even look at this, how long do you think it will take for any new language to get their spell checker working in Evolution. Since not everyone has all the spell checkers installed its seems obvious that this can operate without the spell checker present. So I would suggest adding those languages, they do no harm. Form a localisers perspective the languages are translated in many other applications and instances so there is no real duplication as they can reuse the ir translations. As an ultimate solution I would love to see this code use the translations of ISO639 and just be able to use any aspell checker it finds. Not have to be patched each time to match what dictionaries are available through aspell. And not all of them aree packaged by vendors anyway. So I guess that reverts to... please add those South African languages back. If they're there we'll push our myspell spell checkers to aspell.
dwayne: fair point, i like your argumentation. you convinced me. :-) so, my patch already includes Afrikaans, and your patch includes + "en-ZA", N_("English (South African)"), + "ns", N_("Northern Sotho"), + "tn", N_("Tswana") do you mind to tell me the other 7 (?) south african languages and their corresponding iso 639 abbreviations? i guess they should be added too, shouldn't they? :-/ i'm only going to prepare a patch for all languages covered by iso 639 after having found out if anyone maintains gnome-spell and if thisw is the way to go. your criticism is more than correct, however, i have poked some responsible people within the last days so this hopefully will get fixed for gnome 2.14.
...err... if you've got spell checking abilities for Northern Sotho and Zulu, are they public in any kind of way? hmm.
andre: re #9 I'm listing all 11 here (otherwise I get confused): Name in English - ISO639 Afrikaans - af English (South African) - en-ZA Ndebele, South - nr Northern Sotho - nso # there is no two letter code, my last patch is wrong. Might cause other problem if they don't handle 3 letter codes but I think correctness is better Swati - ss Southern Sotho - st Tswana - tn Tsonga - ts Venda - ve Xhosa - xh Zulu - zu re #10 The spell checkers that we have released are here: zu http://sourceforge.net/project/showfiles.php?group_id=91920&package_id=106128 tn http://sourceforge.net/project/showfiles.php?group_id=91920&package_id=117972 af http://sourceforge.net/project/showfiles.php?group_id=91920&package_id=103504 The other languages are comming as we build up big enough word lists - which has taken much longer then we had hoped. Xhosa had a major shot in the arm but we are still testing it. The main issue we have found is that myspell and aspell are not the best for managing these languages.
dwayne: zu, tn and af are already listed in my patch because they are listed in http://aspell.sourceforge.net/man-html/Supported.html . :-) so i should add the 8 other languages as well as all those languages where an aspell dictionary is not available yet if this is the way to go (have to get feedback from gnome-spell maintainer first *if* he exists - but i promise that i'm going to find a solution for this in time for gnome 2.14 and the existing string freezes that i keep in mind. i already talked to the evolution main maintainer about this here). and since gnome desktop is available in xhosa, we should also really have a dictionary for that (my opinion) - but only because i really like that language and its sounds. :-)
andre: Just to confirm that yes we should have 11 South African languages included in the patch. Spell checkers will come as we develop them. Thanks for your help on this I'm very happy to see this bug moving. Gnome is in fact also partly in Zulu, Afrikaans and Northern Sotho so it would be great to see all these spell checkers working. It has implications for tools like GAIM aswell I think.
just for the records, gaim uses gtk-spell as far as i know.
dwayne, gour, i wrote a patch including hopefully all languages. i have attached it to http://bugzilla.ximian.com/show_bug.cgi?id=62271 , direct access: http://bugzilla.ximian.com/showattachment.cgi?attach_id=16260 . i took a look at the many jhbuild build dependencies for gnome-spell - seems like i have to use a modem for the next eight days, would be cool if someone could check if gnome-spell compiles correctly with my patch included... thanks in advance. :-) ...feedback welcome, like always.
i finally submitted to cvs the gnome-spell patch. i am going to inform gnome-i18n mailing list about the additional strings. for the exact changes, see: http://cvs.gnome.org/viewcvs/gnome-spell/gnome-spell/dictionary.c?r1=1.38&r2=1.39 http://cvs.gnome.org/viewcvs/gnome-spell/gnome-spell/dictionary.h?r1=1.7&r2=1.8 dwayne: thanks for your patience. gour: thanks for testing. yanko: thanks for the code cleanup. i am closing this bug here, though generally i guess that the languages list must be expanded to support ISO 639-3 completely in the end. anyway, this must go into http://bugzilla.ximian.com . :-/
Gnome Spell 1.0.7 "Winter beauty" includes these fixes and has been released today.