GNOME Bugzilla – Bug 148382
This gtk-doc.make allows me to run distcheck sucessfully
Last modified: 2004-12-22 21:47:04 UTC
The one from the cvs prevents all application using it from using the distcheck feature of automake. This one works. Installation/desinstallation is handled by automake (which allows it to respect the srcdir tricks) The make dist does not fail anymore when --enable-gtk-docs is not given. I would say that this option should be renamed to --disable-gtk-docs, and the doc building become the default when gtk-doc is installed. Thanks, Mt.
Created attachment 29865 [details] well, the gtk-doc.make in question ;)
A) GTK+, Pango, Glib, etc 'make distcheck' fine with the current gtk-doc.make, describing your particular failure would be useful. B) Please provide your changes as a patch, we're not going to just replace an entire file. C) We've seen many, many failures from screwed up XML/SGML configurations of one sort or the other. There's absolutely no reason to make people debug them, or for that matter, wait 10 minutes for docs to build, when we can ship tarballs with the docs already there.
A) I only tested gtk+ (version gtk+-2.4.3) and it fails poorly, far before the problem I went into. I can send you the logs if you want, but it is 48K, and it's so easy to reproduce that I dont feel it necessary. I speak about distcheck, not check. B) You are right, I'm a bad person. I'm gonna send the diff just after this edit. C) Alright. Ok. I don't really care whether the use of gtk-doc is the default or not. My issue is that during the distcheck, a make dist is done on a new tree, and when you don't pass --enable-gtk-doc to the configure, you cannot make a dist afterward. But a proper solution is to set DISTCHECK_CONFIGURE_FLAGS to that. Let me update my patch... done. In short, my problems come from the [un]install targets, which does not support vpath builds. It breaks the distcheck target. And also, $(DOC_MODULE).types is not mandatory for gtk-doc (and I don't use it), but it is listed in EXTRA_DIST, which breaks the dist target.
Created attachment 29867 [details] [review] Diff against the CVS version Sorry for the crude big file lastely. I should have produced a patch from the beginning...
A) I'm an idiot. It's just that the dist target only work when 'all' has been done. Sorry.
Closing it then.