GNOME Bugzilla – Bug 148154
Upgrade to GTK+ 2.4.4 cut buttons on Industrial-Engine
Last modified: 2009-06-04 21:19:35 UTC
Friends, I've updated my GTK+ (and GLIB) version from 2.4.1 to 2.4.4. My favourite GTK+ engine is industrial (from Ximian), but some problems appear after the upgrade of the libraries. Some buttons in some specific programs appear "cutted"... (i.e.: the button height apparently is less that normal). I've tested various applications (Gimp 2.0.1, Firefox 0.9.1, Evolution 1.4.6, etc) but i've noticed the problem only in two kinds of applications: -> Java software that uses GTK+ (i.e.: Eclipse) -> Applications written in wxWidgets framework (i.e.: wxDesigner, wxVLC and any written by me) I've noticed the problem with Eclipse v2.1.3 / v3.0.0 and wxDesigner 2.10a. With Java/GTK+ programs, ALL the buttons (without exception) in the applications (Eclipse v2 ou v3) represent the problem. With wxWidgets programs, only SOME buttons in dialogs exhibit this issue. I cant to find a solution: i tried to update to a more recent version of Industrial-Engine (0.2.36-2) and re-compile wxWidgets, but didn't work. The issue remains. I've uplodaded some pics demonstring the problem to my server. See it! - http://www.tisc.com.br/screenshots/shot1.png - http://www.tisc.com.br/screenshots/shot2.png - http://www.tisc.com.br/screenshots/shot3.png - http://www.tisc.com.br/screenshots/shot4.png - http://www.tisc.com.br/screenshots/shot5.png - http://www.tisc.com.br/screenshots/shot6.png Sincerely, Paulo Oliveira Filho mailto:paulo.oliveira@tisc.com.br
I have made a quick test with the industrial theme, and "normal" gtk apps seem to have no problems, so there must be something special done by eclipse and wxWidgets. Does this only show up with industrial, or also with the default theme ?
Hi Matthias, I've bluecurve, cleanice,
Hi Matthias, I've bluecurve, cleanice, lighthouseblue, metal, misc, pixmap, redmond and anothers... This happen only with industrial! =/ Thanks... Paulo
I have no idea how a theme can influence the button size in this way. Does this happen with "normal" gtk apps as well ?
Matthias, Hi... Sorry by delay... I was out last weekend... Answering your question: No!!! With pure GTK apps this issue doesn't happen! Look at new screenshots that i take now: - http://www.tisc.com.br/screenshots/shot7.png - http://www.tisc.com.br/screenshots/shot8.png - http://www.tisc.com.br/screenshots/shot9.png - http://www.tisc.com.br/screenshots/shot10.png 1. The 1st pic demonstrates that GTK apps are ok! My Firefox 0.9.1 (compiled against gtk2+xft) show buttons with industrial-engine correctly! 2. The 2nd and 3rd pics shows two windows side-by-side in wxWidgets-apps affected by issue with industrial-theme versus Mist and Glossy P (pixmap engine) themes. A theme might not influence the button size, but a ENGINE may influence, maybe not? I see too that "dialog boxes" which contains buttons with icons (even in wxWidgets applications) doesnt show the issue with the buttons (see the shot10).
Maybe this is related to this bug: http://bugs.ximian.com/show_bug.cgi?id=58350
This bug is caused by a change added in GTK+ 2.4.2 to stop the children of buttons from overwriting the focus rectangle in the button. It affects Eclipse because we were setting button height based on font size plus padding values which were not large enough to account for the space required by the focus rectangle plus the large border around the outside of the button. Our button height code was based on the Windows human interface guidelines and could have been broken in other ways by themes which add large amounts of padding (smooth engine based themes in particular). It may be that wxWidgets applications are doing something similar. We have fixed this issue in the 3.1 branch of Eclipse by simply not setting the height on our buttons. See http://vektor.ca/eclipse/gtk-button-size.html for references to the Eclipse bugs on this issue. A possible change in GTK+ that would help work around this for users of Eclipse 3.0 and earlier (at least for some themes) would be to let button contents draw on top of the focus rectangle padding if the button is sized smaller than its minimum size.
I noticed this problem too. There are many glitches with wxwidgets 2.5.3, for examples radio buttons don't work at all, but there are problems with gtk apps too. Here are some screenshots: radio buttons: http://ghepeu.altervista.org/immagini/industrial/radio-button-industrial.jpg http://ghepeu.altervista.org/immagini/industrial/radio-button-cleanice.jpg add button (in file chooser): http://ghepeu.altervista.org/immagini/industrial/add-button-industrial.jpg http://ghepeu.altervista.org/immagini/industrial/add-button-cleanice.jpg this happens in both gnome 2.x and xfce4.x, at the moment I've got gtk+ 2.4.13 and glib 2.4.8, but I noticed these glitches several months ago.
Vektor, you promised a patch for the overdraw-if-too-small approach...
radiobox buttons problem seems to be fixed in current wxWidgets CVS.
Is this still an issue in gtk 2.12?
I assume it's not. If it is, please reopen.