After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 147819 - [PATCH] Add some checks in the opt scheduler
[PATCH] Add some checks in the opt scheduler
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.8.3
Other Linux
: Normal blocker
: 0.8.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-07-18 12:39 UTC by Andy Wingo
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the segfaults (2.32 KB, patch)
2004-07-18 12:42 UTC, Andy Wingo 		none Details | Review
new patch (1.89 KB, patch)
2004-07-19 16:10 UTC, Wim Taymans 		none Details | Review

Description Andy Wingo 2004-07-18 12:39:40 UTC 
The attached patch adds some checks to the opt scheduler. The group check will
segfault if the element's sched has been unset, so there is an intermediate
check there. Also, if a group that was enabled and on the runqueue becomes
disabled during the execution of another group, opt still tries to run it, which
doesn't really work.
Comment 1 Andy Wingo 2004-07-18 12:42:26 UTC 
Created attachment 29627 [details] [review]
Patch to fix the segfaults

I'm not sure if this is the right place for checking for a disabled group.
Meaning, I'm not sure if it's the right fix, or if it's just papering over
another problem.
Comment 2 Wim Taymans 2004-07-19 16:10:23 UTC 
Created attachment 29653 [details] [review]
new patch

new patch, uses an existing function to safely get the group of an element.
removed one of the g_warnings as it still fails the testsuite that way.
Comment 3 Thomas Vander Stichele 2004-07-20 10:40:30 UTC 
Ronald says this makes RB unable to play. marking as blocker.
Comment 4 Thomas Vander Stichele 2004-07-20 10:40:48 UTC 
fixed in cvs.