After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 147259 - gnome_vfs_uri_resolve_relative segfaults on 64bit arches
gnome_vfs_uri_resolve_relative segfaults on 64bit arches
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: URI handling
2.6.x
Other Linux
: High major
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2004-07-10 10:56 UTC by Josselin Mouette
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Fix for gnomeVFS 2.6.1.1 (451 bytes, patch)
2004-07-10 10:57 UTC, Josselin Mouette
none Details | Review

Description Josselin Mouette 2004-07-10 10:56:43 UTC
See http://bugs.debian.org/240480

In gnome-vfs-uri.c, make_full_uri_from_relative includes a double cast (char *
-> int -> gchar *) that segfaults on 64bit arches, where pointers and int are
not the same.

Patch follows.
Comment 1 Josselin Mouette 2004-07-10 10:57:32 UTC
Created attachment 29403 [details] [review]
Fix for gnomeVFS 2.6.1.1
Comment 2 Danielle Madeley 2004-07-11 05:48:43 UTC
Adding the PATCH and 'portability' keywords.
Comment 3 Christophe Fergeau 2004-07-11 08:35:34 UTC
Looks fine, feel free to commit. Any specific reason for changing the gchar* to
a char* ?
Comment 4 Josselin Mouette 2004-07-11 08:38:46 UTC
Well, there was no real reason for tmp to be a gchar*. separator is a char* and
strrchr returns a char*. I don't think that matters much, anyway.
Comment 5 Alexander Larsson 2004-07-16 08:20:23 UTC
The fix is in cvs now.