GNOME Bugzilla – Bug 145356
Multiple contractions used in nautilus messages
Last modified: 2008-07-16 16:47:44 UTC
The GNOME Documentation Style Guide says not to use "contractions such as can't, don't, or isn't." This is for emphasis and clarity, which aid users and translators. The number of contractions is too large for me to list them all in this description, so I will attach them, along with a patch.
Created attachment 29188 [details] List of messages that contain contractions
Created attachment 29189 [details] [review] Proposed patch
nautilus has branched so I'm removing the BLOCKED_BY_FREEZE keyword
Alexander: can you send this to nautilus-list so the maintainers review it?
A quick test revealed that this patch doesn't apply cleanly anymore. Maybe you could update it to CVS HEAD? It would be nice to have this usability improvement for GNOME 2.12 :).
Alex?
Created attachment 47356 [details] [review] updated patch that should apply cleanly Sorry about the delay. How's this?
Alexander: Great, thanks for your efforts. It still applies cleanly. Maybe you could send it to nautilus-list [1] for review? [1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Sorry, it doesn't apply cleanly anymore. Failed hunk: *************** *** 239,245 **** send_emblems_changed (); } else { error = g_strdup_printf (_("Couldn't remove emblem with name '%s'."), emblem_sidebar->details->popup_emblem_display_name); - eel_show_error_dialog (error, _("This is probably because the emblem is a permanent one, and not one that you added yourself."), _("Couldn't Remove Emblem"), NULL); g_free (error); --- 239,245 ---- send_emblems_changed (); } else { error = g_strdup_printf (_("Couldn't remove emblem with name '%s'."), emblem_sidebar->details->popup_emblem_display_name); + eel_show_error_dialog (error, _("This is probably because the emblem is a permanent one, and not one you added yourself."), _("Couldn't Remove Emblem"), NULL); g_free (error); I remember to have committed a patch which adapts both of these strings to include a "that". Maybe you could either remove that part or change both of them back to include no "that". Sorry, English is not my mother tongue and I wasn't sure which one is better.
*** Bug 322931 has been marked as a duplicate of this bug. ***
Some of these are still there, but we're again in string freeze. Setting 2.24 target.
Created attachment 108228 [details] [review] patch Updated patch.
For what it is worth, I think it is a good idea to go forward with this patch. Text without contractions generally looks more solid and polished, it is one of the basics of good writing.
Committed to trunk, should be fixed. If you find some other contractions please ping so that we can remove them completely for 2.24. 2008-04-01 Cosimo Cecchi <cosimoc@gnome.org> * libnautilus-private/nautilus-file-operations.c: (delete_dir), (prompt_empty_trash), (verify_destination), (copy_move_directory), (remove_target_recursively), (copy_move_file): * libnautilus-private/nautilus-mime-actions.c: (report_broken_symbolic_link), (activate_files): * libnautilus-private/nautilus-program-choosing.c: (application_cannot_open_location), (nautilus_launch_application), (nautilus_launch_desktop_file): * src/file-manager/fm-error-reporting.c: (fm_report_error_loading_directory), (fm_report_error_renaming_file), (fm_report_error_setting_group), (fm_report_error_setting_owner), (fm_report_error_setting_permissions): * src/file-manager/fm-properties-window.c: (fm_properties_window_drag_data_received), (create_permissions_page): * src/nautilus-application.c: (nautilus_application_startup): * src/nautilus-connect-server-dialog-main.c: (display_error_dialog): * src/nautilus-connect-server-dialog.c: (connect_to_server): * src/nautilus-emblem-sidebar.c: (nautilus_emblem_sidebar_delete_cb), (rename_dialog_response_cb): * src/nautilus-information-panel.c: (receive_dropped_uri_list): * src/nautilus-property-browser.c: (remove_pattern), (remove_emblem), (add_pattern_to_browser): * src/nautilus-window-manage-views.c: (display_view_selection_failure): Do not use contractions in strings. (#145356).
*** Bug 311164 has been marked as a duplicate of this bug. ***