After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 145338 - [PATCH] Fix a bus error in the optimal scheduler
[PATCH] Fix a bus error in the optimal scheduler
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other FreeBSD
: Normal major
: 0.8.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-07-03 03:57 UTC by Joe Marcus Clarke
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix bus error in optimal scheduler (726 bytes, patch)
2004-07-03 03:57 UTC, Joe Marcus Clarke
none Details | Review

Description Joe Marcus Clarke 2004-07-03 03:57:13 UTC
When starting a new game in monkey-bubble 0.3.2 with malloc debugging enabled in
FreeBSD, gstreamer crashes on SIGBUS in the optimal scheduler.

  • #0 gst_opt_scheduler_pad_unlink
    at gstoptimalscheduler.c line 2321
  • #1 gst_scheduler_pad_unlink
    at gstscheduler.c line 186
  • #2 gst_pad_unlink
    at gstpad.c line 1010
  • #3 gst_element_remove_pad
    at gstelement.c line 1181
  • #4 gst_ogg_demux_get_type
    from /usr/X11R6/lib/gstreamer-0.8/libgstogg.so
  • #5 gst_ogg_demux_get_type
    from /usr/X11R6/lib/gstreamer-0.8/libgstogg.so
  • #6 gst_ogg_demux_get_type
    from /usr/X11R6/lib/gstreamer-0.8/libgstogg.so
  • #7 gst_element_set_state
    at gstelement.c line 2735
  • #8 gst_bin_change_state
    at gstbin.c line 755
  • #9 gst_pipeline_change_state
    at gstpipeline.c line 174
  • #10 gst_element_set_state
    at gstelement.c line 2735

The problem looks to be triggered by the fact that when group->num_elements is
0, group is unref'd, but that is made apparent to the original calling function.

With the attached patch, the crash is fixed.  I hope this is the right solution.
Comment 1 Joe Marcus Clarke 2004-07-03 03:57:55 UTC
Created attachment 29177 [details] [review]
Fix bus error in optimal scheduler
Comment 2 Thomas Vander Stichele 2004-07-06 11:44:27 UTC
correct fix, commited, closing.