After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 145103 - Replaygain use should be optional
Replaygain use should be optional
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 342074 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-06-28 20:48 UTC by Ash
Modified: 2006-12-18 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add gconf value (1.41 KB, patch)
2006-07-22 01:30 UTC, James 		none Details | Review
Forgot to patch the gconf schema file, oops. (2.31 KB, patch)
2006-07-22 01:44 UTC, James 		none Details | Review

Description Ash 2004-06-28 20:48:41 UTC 
Imagine some of my music collection is replaygained, and some is not. When I hit
an ungained track (or an mp3 that *is* replaygained but from which the info
isn't extracted (it is in an APEv2 tag)), suddenly I have to lunge for the
volume control. This is not ideal.
A basic solution is to have replaygain toggleable.
A better solution is to have it toggleable and have a option to set the amount
by which the volume of tracks without recognised RG info is reduced, and/or an
option to boost the volume of RG tracks by a certain amount (but this is bad,
since it will sometimes introduce clipping).
Comment 1 James "Doc" Livingston 2006-05-23 02:17:46 UTC 
*** Bug 342074 has been marked as a duplicate of this bug. ***
Comment 2 James 2006-05-26 05:00:12 UTC 
Please fix soon, this is really annoying.
Comment 3 James 2006-07-22 01:30:34 UTC 
Created attachment 69369 [details] [review]
Patch to add gconf value

This is my first GTK patch ever.  I tested it on my system and did not have any problems with it.  Hope it helps.
Comment 4 James 2006-07-22 01:44:53 UTC 
Created attachment 69370 [details] [review]
Forgot to patch the gconf schema file, oops.

This will have rhythmbox box check the GConf value /apps/rhythmbox/use_replaygain before enabling replaygain.  By default, replaygain is disabled.
Comment 5 James "Doc" Livingston 2006-12-18 13:12:34 UTC 
I've committed this to cvs (just in time for 0.9.7). Thanks.