After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144704 - Move gnome-open.c to libgnomeui and make it call gnome_authentication_manager_init()
Move gnome-open.c to libgnomeui and make it call gnome_authentication_manager...
Status: RESOLVED OBSOLETE
Product: libgnomeui
Classification: Deprecated
Component: general
2.15.x
Other All
: High major
: ---
Assigned To: libgnomeui maintainers
libgnomeui maintainers
: 394887 (view as bug list)
Depends on: 309127
Blocks:
 
 
Reported: 2004-06-20 16:56 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2009-05-03 20:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Proposed patch (against HEAD). (3.30 KB, patch)
2005-05-07 08:04 UTC, Christian Neumair
rejected Details | Review

Description Dave Bordoley [Not Reading Bug Mail] 2004-06-20 16:56:27 UTC
Opening sftp:// urls fails using gnome-open and other programs based on the
gnome_vfs_url_show. Probably and easy fix is to make nautilus the default
handler for these.
Comment 1 Alexander Larsson 2004-06-23 15:25:15 UTC
Having url-handlers for full uris has problems. It causes nautilus to not use
its normal machinery to open a directory. Instead it just launches the app with
the uri as argument. Not a very efficient way to open a folder. So, this
probably shouldn't be done.
Comment 2 Sebastien Bacher 2004-09-21 14:05:38 UTC
Does it affect the normal behaviour (apparently not, I've just set epiphany has
ftp:// handler and the ftp still works fine in nautilus) ? 

If it only happens with gnome-open I don't really get the problem. We have the
choice between no support for gnome-open and a "not very efficient way" ... the
not efficient way seems to work fine here.
Comment 3 Reinout van Schouwen 2005-02-08 17:07:10 UTC
With the file types and properties capplet gone, is there still a way to set the
ftp:// handler apart from manually editing the gconf database?

Setting version 2.9/2.10, since it still occurs there.
Comment 4 Christian Neumair 2005-05-07 07:52:48 UTC
Alex: But the internal mechanism you talk about isn't known to gnome-open, of
course; except if you add an additional parameter which tells nautilus to use
its internal directory loading mechanism. For now I think it's perfectly OK to
associate nautilus with ftp/sftp URIs.
Comment 5 Christian Neumair 2005-05-07 08:04:51 UTC
Created attachment 46123 [details] [review]
Proposed patch (against HEAD).

After applying this patch, users will at least be able to gnome-open their
sftp/ftp folders. If one passes a file, nautilus yells that this isn't a
folder. IMHO it should try to launch the application associated with this MIME
type and only bail if none exists/could be launched, telling the user that
there is no application installed suitable to display this URI. But then again,
maybe we shouldn't shift that much functionality into nautilus and have some
internal meachanism to check the mime type first.
Comment 6 Luis Villa 2005-07-08 15:25:18 UTC
Christian: i'd suggest making the command 'nautilus --browser' instead of
'nautilus' by default, since spatial is a little more confusing on remote
machines (IMHO).

But yeah, otherwise... the choice here seems clearly between 'inefficient' and
'totally completely broken', so surely we should go with inefficient?

Given that this means that by default ftp support in epiphany is broken
(AFAICT), marking up.
Comment 7 Allison Karlitskaya (desrt) 2005-07-08 15:47:34 UTC
I prefer spatial everywhere (often using nautilus and sftp) and it's certainly
better to respect the user's stated preference.
Comment 8 Christian Neumair 2005-07-08 17:18:35 UTC
Also note that if we don't fix bug 309127, this patch might not be that helpful
after all, since people trying to open sftp://user:foo@mymachine/foobar/bar.tbz2
won't succeed.
Comment 9 Lionel Dricot 2006-03-26 22:30:53 UTC
Also discussed here :
https://launchpad.net/products/gnome-vfs/+bug/8306
Comment 10 Oliver Gerlich 2006-05-15 21:38:12 UTC
What is the current status of this bug report? Just asking because the problem described has struck me in service-discovery-applet recently (https://launchpad.net/distros/ubuntu/+source/service-discovery-applet/+bug/42393).

Does the proposed fix work? Or is there another possible fix?

Thanks,
Oliver
Comment 11 Alexander “weej” Jones 2006-08-23 16:08:48 UTC
Calling gnome_vfs_get_file_info with a URI with login credentials supplied works perfectly, even for directory locations.

Something somewhere up the chain in gnome-open needs to detect the login failure and invoke the "Authentication Required" dialogue that is apparently in libgnomeui.

I don't know exactly the best way of doing this, but hopefully someone will be inspired a bit.

An unfortunate side-effect would be that to fork the application, you would need to pass a URI complete with username and password as a process launch argument. Pretty bad security hole. Perhaps we should start passing tokens around or something.
Comment 12 Alexander Larsson 2006-08-28 10:13:19 UTC
We used to have a handler for ftp: similar to the one you propose here, and it generated all sorts of bugs, so that was removed. Seem better to fix the bug.

Seems like gnome-open needs to call gnome_authentication_manager_init().
Comment 13 Alexander Larsson 2006-08-28 10:15:47 UTC
Also, with the proposed workaround, won't all sftp:// urls will be opened in nautilus, including for instance a text file you click on in a sftp directory.
Comment 14 Kjartan Maraas 2006-10-05 10:53:16 UTC
Fixing the component.
Comment 15 Kjartan Maraas 2006-10-23 14:27:45 UTC
Should the call to gnome_authentication_manager_init() be placed before or after gnome_program_init()?
Comment 16 Alexander Larsson 2006-10-24 06:59:35 UTC
After.
Comment 17 Kjartan Maraas 2006-12-02 12:30:30 UTC
but doesn't that also make libgnome depend on libgnomeui? maybe gnome-open should be moved over to the ui part of the libs?
Comment 18 Alexander Larsson 2006-12-04 08:51:44 UTC
Yeah, thats probably required.
Comment 19 Kjartan Maraas 2006-12-05 07:45:21 UTC
I see there's a suggestion to move it to gnome-vfs on the libgnome/ui must die page. How do you feel about that?
Comment 20 Alexander Larsson 2006-12-05 09:23:56 UTC
Gnome-vfs doesn't use Gtk+ though, so that would change the build requirements. Furthermore, I'm working on gvfs to replace gnome-vfs and would like to avoid adding stuff to a to-be-deprecated module.
Comment 21 Kjartan Maraas 2007-01-09 00:28:13 UTC
I'll move it to libgnomeui then and add the call to gnome_authentication_manager_init()
Comment 22 Kjartan Maraas 2007-01-10 14:12:26 UTC
*** Bug 394887 has been marked as a duplicate of this bug. ***
Comment 23 Kjartan Maraas 2007-02-03 15:11:08 UTC
Will do this when we branch after 2.18.x
Comment 24 Kjartan Maraas 2008-09-10 19:32:48 UTC
Now gnome-open was ported to GIO at least.
Comment 25 Kjartan Maraas 2009-05-03 20:24:04 UTC
gnome-open has been replaced by gvfs-open.