After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144631 - preferences dialog should be center on the parent window
preferences dialog should be center on the parent window
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-06-19 00:32 UTC by Diego González
Modified: 2005-06-25 02:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This attachment contains a patch that displays the preferences dialog in the center. (732 bytes, patch)
2004-12-30 06:55 UTC, Naveen Chandran V
none Details | Review
patch (32.25 KB, patch)
2005-06-24 16:42 UTC, Paolo Borelli
none Details | Review

Description Diego González 2004-06-19 00:32:49 UTC
as summary says
Comment 1 Naveen Chandran V 2004-12-30 06:55:25 UTC
Created attachment 35286 [details] [review]
This attachment contains a patch that displays the preferences dialog in the center.

This patch makes the preferences dialog display in the center.

Here is the Change Log Entry

2004-12-30 Naveen & Team < naveenchandranv@gmail.com >

    * Fixed bug #144631 (http://bugzilla.gnome.org/show_bug.cgi?id=144631).
      Displays the EOG Preferences window in the center.
Comment 2 Naveen Chandran V 2005-03-20 14:23:55 UTC
ping
Comment 3 Paolo Borelli 2005-06-24 16:40:32 UTC
the above patch is bogus: among it centers the window on the screen not on the
parent instance.

The follwing patch fixes the bug properly doing the following things:
- Change the preferences from being a GtkWindow to being a proper GtkDialog in
the  glade file
- change the api in order to pass the parent GtkWindow to the pref dialog
- set the pref dialog transient to the parent

(note glade insisted in adding some more stuff in the diff, I didn't trim so
that the patch applyes cleanly)
Comment 4 Paolo Borelli 2005-06-24 16:42:25 UTC
Created attachment 48281 [details] [review]
patch
Comment 5 Tim Gerla 2005-06-25 02:13:19 UTC
Applied Paolo's patch, thanks Paolo and Naveen.