After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144624 - wavenc doesn't close file properly
wavenc doesn't close file properly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.2
Other Linux
: Normal normal
: 0.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 144625 145155 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-06-18 20:18 UTC by Sebastien Cote
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastien Cote 2004-06-18 20:18:02 UTC 
When the wavenc stops, it seeks to the beginning of the file to update the
headers using 

  event = gst_event_new_seek (GST_FORMAT_BYTES | GST_SEEK_METHOD_SET, 0);
  gst_pad_send_event (GST_PAD_PEER (wavenc->srcpad), event);


It don't know why but this doesn't seek to the beginning.  It can be fixed by
using  
  event = gst_event_new_seek (GST_FORMAT_BYTES | GST_SEEK_METHOD_SET, 0);
  gst_pad_push(wavenc->srcpad, GST_DATA(event));

I'm not sure if the bug is in gst_pad_send_event() or wavparse.
Comment 1 Benjamin Otte (Company) 2004-06-20 20:29:56 UTC 
it should send a discontinuous event, seek events are upstream only.
Comment 2 Benjamin Otte (Company) 2004-06-20 20:30:13 UTC 
*** Bug 144625 has been marked as a duplicate of this bug. ***
Comment 3 Ronald Bultje 2004-06-20 22:47:08 UTC 
Actually, right now, seek/discont can be used interchangeably downstream.

For 0.9.x, we need to choose either one.
Comment 4 Sebastien Cote 2004-06-21 14:01:53 UTC 
filesink handles GST_EVENT_DISCONTINUOUS as well as GST_EVENT_SEEK.  Using

  event = gst_event_new_discontinuous (FALSE, GST_FORMAT_BYTES, (gint64) 0, NULL);
  gst_pad_send_event (GST_PAD_PEER (wavenc->srcpad), event);

doesn't work either.  The problem here seems to be gst_pad_send_event() because
its working using gst_pad_push().
Comment 5 David Schleef 2004-07-03 00:45:38 UTC 
Changing to gst_pad_push() doesn't fix the problem for me.
Comment 6 David Schleef 2004-07-03 03:02:28 UTC 
part of the problem is that wavenc was not writing the header correctly at EOF.
 It's fixed now.  Note that we still don't write the header correctly if there's
no EOS on the stream.
Comment 7 David Schleef 2004-07-04 00:09:22 UTC 
*** Bug 145155 has been marked as a duplicate of this bug. ***