After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144616 - Infinite loop in wavparse.
Infinite loop in wavparse.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.2
Other Linux
: Urgent critical
: 0.8.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-06-18 18:52 UTC by Sebastien Cote
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (870 bytes, patch)
2004-06-18 18:54 UTC, Sebastien Cote 		none Details | Review
Proposed fix (v2) (1.46 KB, patch)
2004-06-18 19:23 UTC, Sebastien Cote 		none Details | Review

Description Sebastien Cote 2004-06-18 18:52:11 UTC 
With gst-plugins-0.8.1.2, pipelines like this one;
gst-launch-0.8 --gst-scheduler=entrygthread filesrc=somefile.wav ! wavparse !
spider ! esdsink

get stuck in an infinite loop very often.  I traced the problem back to
riff-read.c which unrefs EOS in gst_riff_read_skip() without doing anything with
it.  The next time bytestream calls gst_pad_pull(), the pipeline gets stuck.
Comment 1 Sebastien Cote 2004-06-18 18:54:14 UTC 
Created attachment 28841 [details] [review]
Proposed fix

Handling events in gst_riff_read_skip() like it's done in the rest of the file
fixes the problem.
Comment 2 Sebastien Cote 2004-06-18 19:23:16 UTC 
Created attachment 28842 [details] [review]
Proposed fix (v2)

Seems like calling GST_IS_EVENT (event) without checking if event was NULL
wasn't such a good idea.  

This problem was also in the original code, fixed both.
Comment 3 Ronald Bultje 2004-06-18 20:24:22 UTC 
Looks good, please apply.
Comment 4 Christophe Fergeau 2004-08-16 11:26:08 UTC 
What's up with that bug? Has the patch been applied? Can it be closed?
Comment 5 Sebastien Cote 2004-08-24 17:39:14 UTC 
The patch hasn't been applied yet, the version in CVS is still buggy.
Comment 6 Christophe Fergeau 2004-08-24 18:25:15 UTC 
OK, I committed this patch to HEAD since it had been reviewed by Ronald.