GNOME Bugzilla – Bug 144240
[cdparanoia] sets wrong timestamps on buffers [patch]
Last modified: 2004-12-22 21:47:04 UTC
cdparanoia sets consecutive timestamps on buffers (just for the sake of having a timestamp, it seems), which are just steadily increased and not affected by seeking, changing of tracks etc. This means that a query on the audiosink (or cdparanoia) will produce a time stamp that has no relation to the position currently being played back, which seems very undesirable for audio players etc. Instead, cdparanoia should set timestamps on buffers that represent the current position within the CD, ie. since the start of the CD, and send discont events on seeking/track changing IMHO. Patch attached. I realise the hack with g_object_{get|set}_qdata() is ugly, but it's the only sane way I could come up with to compensate for the missing padding. Tested with alsasink and artsdsink. Cheers -Tim
Created attachment 28647 [details] [review] proposed patch
Created attachment 28656 [details] [review] proposed patch (sane version) Erm, please ignore the first patch and pretend you've never seen it. New patch attached, without all the unnecessary _{get|set}_qdata() stuff. Cheers -Tim
There's still a comment about padding in there - it's unneeded. Padding only applies to public exported ABI/API. :).
Created attachment 28658 [details] [review] proposed patch For some reason I thought plugin headers were semi-public as well, sorry. New patch without those comments attached. Cheers -Tim
Applied, thanks.