GNOME Bugzilla – Bug 144091
[Solaris] audio mixer element
Last modified: 2004-12-22 21:47:04 UTC
When gnome-volume-control is started on a solaris machine an error dialog with the following information is displayed "Sorry, no mixer elements and/or devices found"
That is the correct behaviour until one of the GNOME/Solaris hackers writes a mixer-element as part of the sunaudio GStreamer plugin.
Re-assign to GStreamer.
Created attachment 30003 [details] [review] Patch for this problem Attaching a patch which adds a mixer element to the sunaudio plugin. With this patch, gnome-volume-control comes up with three sliders (Volume, Gain, Monitor). Please give your comments. Thanks.
Nicely based on ossmixer, no? ;). Please remove the "#define _(s) s" in the *mixer.c, it's too obvious. ;). gstsunaudioelement.h:GstSunAudioElement also defines a very large struct but seems to use only very few of them. Could you clean up the unused struct members? Apart from that, great work, thanks!
Created attachment 30032 [details] [review] Patch for this bug Yeah, this is totally based on oss mixer :). I have removed the #define _(s) s and also cleaned up the unsed struct members. Thanks for reviewing the patch. Thanks
Something else, I noticed that the members in Sun's audio/kernel interface struct are called gain, record.volume and play.volume, you call them monitor, gain and volume. What's the difference? And are there more? This sounds like there's very little audio support in Solaris. ;). Note that those are comments of someone unfamiliar to Solaris, so this might all be correct. I'm just double checking before accpeting the patch.
The play.gain and record.gain fields specify the output and input volume levels. A value of AUDIO_MAX_GAIN indicates maximum volume. Most audio devices allow input data to be monitored by mixing audio input onto the output channel. The monitor_gain field controls the level of this feedback path.(From Solaris Answer book) Currently the patch supports only volume, gain, monitor. Later will add support for other input and output ports
I intended to hold off on applying this patch until I could check it on my machine, but that has not happened yet. Unless someone finds issues with the patch, it should be applied before the next release.
Applied.