GNOME Bugzilla – Bug 143861
OSS elements portability on BSD (soundcard.h location)
Last modified: 2004-12-22 21:47:04 UTC
as the devel-mailing seems to work when it wants (not very often), i post a "potential" bug here. some BSD that have OSS emulation (Free/Net/OpenBSD), have put (or still do) their soundcard.h in INCLUDEDIR/, INCLUDEDIR/machine/ and sometimes INCLUDEDIR/sys (like current linux does) configure.ac only checks for sys/soundcard.h oss & arts plugins only include sys/soundcard.h first question : is arts OSS specific ? i see no check for OSS presence in configure.ac arts detection section would attach a patch in the near future that should fix this any BSD people can tell me where this header is on their system and which version they use ?
xine includes taken from from http://cvs.sourceforge.net/viewcvs.py/*checkout*/xine/xine-lib/src/audio_out/audio_oss_out.c?content-type=text%2Fplain&rev=1.109 #if defined(__OpenBSD__) # include <soundcard.h> #elif defined (__FreeBSD__) # if __FreeBSD__ < 4 # include <machine/soundcard.h> # else # include <sys/soundcard.h> # endif #else # include <sys/soundcard.h> #endif libao (Xiph's audioout lib) taken from http://svn.xiph.org/trunk/ao/src/plugins/oss/ao_oss.c #if defined(__OpenBSD__) || defined(__NetBSD__) #include <soundcard.h> #else #include <sys/soundcard.h> #endif esound taken from http://cvs.gnome.org/viewcvs/esound/configure.in?rev=1.94&view=auto in configure.in uses AC_CHECK_HEADERS(soundcard.h sys/soundcard.h machine/soundcard.h) and ifdefs based on that. mplayer taken from http://www1.mplayerhq.hu/cgi-bin/cvsweb.cgi/main/configure?rev=1.866&content-type=text/x-cvsweb-markup (muhahaha) does basically the same as esound. It only checks for sys/soundcard.h and soundcard.h though. Based on that my suggestion would be to copy from esound.
Created attachment 28423 [details] [review] look for soundcard.h in 3 different dirs for BSD portability could someone verify the arts section ? (as it includes sys/soundcard.h without any check on OSS presence)
commited i let it open for feedback from BSD people
Not needed, they'll reopen when there's a new bug. ;).