Bug 143829 – window groups render Ctrl+S search unusable

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 143829 - window groups render Ctrl+S search unusable


Summary:	window groups render Ctrl+S search unusable


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	Widget: GtkTreeView
Version:	2.4.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtktreeview-bugs
QA Contact:	gtktreeview-bugs

URL:
Whiteboard:

Duplicates:	162475 168176 (view as bug list)
Depends on:
Blocks:	167386

Reported:	2004-06-06 20:32 UTC by Tommi Komulainen
Modified:	2011-02-04 16:17 UTC

See Also:
GNOME target:	---
GNOME version:	2.9/2.10

Attachments
Testcase (403 bytes, text/plain) 2004-06-06 20:34 UTC, Tommi Komulainen		Details
Testcase, the right one (463 bytes, text/plain) 2004-06-06 20:36 UTC, Tommi Komulainen		Details
testcase which also demonstrates a crash (719 bytes, text/plain) 2005-02-14 19:54 UTC, Christian Persch		Details
proposed fix (2.39 KB, patch) 2005-02-14 20:19 UTC, Christian Persch	none	Details \| Review

Description Tommi Komulainen 2004-06-06 20:32:48 UTC

If one adds GtkFileChooserDialog in a window group of its own (in order to
minimize modality effects) the Ctrl+S search entry stops receiving any keypresses.

Comment 1 Tommi Komulainen 2004-06-06 20:34:39 UTC

Created attachment 28398 [details]
Testcase

Ctrl+S search works as expected if the following line is omitted.

	gtk_window_group_add_window (group, GTK_WINDOW (chooser));

Comment 2 Tommi Komulainen 2004-06-06 20:36:16 UTC

Created attachment 28399 [details]
Testcase, the right one

Comment 3 Owen Taylor 2004-06-07 12:04:14 UTC

GtkTreeView issue I expect, though I'm not sure what's going on in
detail ... might want to compare what gtk_menu_popup() does though the
treeview search dialog is a bit different since it doesn't do a 
pointer/keyboard grab.

Comment 4 Christian Persch 2005-02-14 19:54:46 UTC

Created attachment 37466 [details]
testcase which also demonstrates a crash

This testcase demontrates that this bug also leads to a crash.

Steps to reproduce:
0) Create file "test"
1) Run the testcase
2) Type "te" (without quotes)
3) Click "Open"

Actual results:
A warning on console + crash.
(400:2884): GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT
(object)' failed

Trace from warning:
Breakpoint 2, 0xb7b83e24 in g_return_if_fail_warning ()
   from /usr/lib/libglib-2.0.so.0
(gdb) where

+ Trace 55704

#0 g_return_if_fail_warning
from /usr/lib/libglib-2.0.so.0
#1 g_object_ref
from /usr/lib/libgobject-2.0.so.0
#2 send_focus_change
at gtktreeview.c line 8874
#3 gtk_tree_view_search_dialog_hide
at gtktreeview.c line 12277
#4 gtk_tree_view_search_entry_flush_timeout
at gtktreeview.c line 8859
#5 g_main_context_wakeup
from /usr/lib/libglib-2.0.so.0
#6 g_main_depth
from /usr/lib/libglib-2.0.so.0
#7 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#8 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#9 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#10 IA__gtk_main
at gtkmain.c line 963
#11 main
#0 send_focus_change
at gtktreeview.c line 8879
#1 gtk_tree_view_search_dialog_hide
at gtktreeview.c line 12277
#2 gtk_tree_view_search_entry_flush_timeout
at gtktreeview.c line 8859
#3 g_main_context_wakeup
from /usr/lib/libglib-2.0.so.0
#4 g_main_depth
from /usr/lib/libglib-2.0.so.0
#5 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#6 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#7 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#8 IA__gtk_main
at gtkmain.c line 963
#9 main

Comment 5 Christian Persch 2005-02-14 19:58:47 UTC

*** Bug 162475 has been marked as a duplicate of this bug. ***

Comment 6 Christian Persch 2005-02-14 20:19:08 UTC

Created attachment 37467 [details] [review]
proposed fix

This patch fixes the problem for me.

Comment 7 Jürg Billeter 2005-02-16 14:38:57 UTC

Thanks for the patch, I can confirm that my epiphany crashes in bug 162475 don't
happen anymore.

Comment 8 Matthias Clasen 2005-02-16 16:40:06 UTC

2005-02-16  Matthias Clasen  <mclasen@redhat.com>

	Fixes for #143829, Tommi Komulainen, Christian Persch:
	
	* gtk/gtktreeview.c (gtk_tree_view_destroy): Remove the
	typeselect_flush_timeout when destroying the widgets
	it is operating on.  
	(gtk_tree_view_ensure_interactive_directory): Add the 
	popup to the window group of the toplevel it belongs to.

	* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget) 
	(gtk_combo_box_popup): Do the same here.

Comment 9 Christian Persch 2005-02-22 19:28:29 UTC

*** Bug 168176 has been marked as a duplicate of this bug. ***