GNOME Bugzilla – Bug 143251
GtkFileChooserEntry pulldown icons
Last modified: 2014-12-23 11:53:51 UTC
The GtkFileChooserEntry widget (used by the ctrl+l dialog) currently does not show icons next to filenames, though the file chooser does display icons in the list itself.
Created attachment 28062 [details] [review] Patch to implement mimetype icons in the GtkFileChooserEntry completion
Thanks for the patch! Instead of hard-coding 16 as an icon size, use impl->icon_size, which gets computed from the theme.
Created attachment 28215 [details] [review] Updated patch to use SMALL_TOOLBAR icon size and monitor size changes
Created attachment 28218 [details] [review] Last patch minus the "invalid signal" emission.
ping : can this patch be applied ?
This patch needs to also override the "screen-changed" signal with something like this: static void gtk_file_chooser_entry_screen_changed (GtkWidget *widget, GdkScreen *previous_screen) { GtkFileChooserEntry *entry; entry = GTK_FILE_CHOOSER_DEFAULT (widget); if (GTK_WIDGET_CLASS (parent_class)->screen_changed) GTK_WIDGET_CLASS (parent_class)->screen_changed (widget, previous_screen); if (entry->settings_notify_id) { g_signal_handler_disconnect (gtk_settings_get_for_screen (previous_screen), entry->settings_notify_id); entry->settings_notify_id = 0; } check_icon_theme (entry); } Unfortunately, I'm unable to easily do this myself, as I've only got barebones browser access to the Internet until the 17th.
James : can you provide an updated version of the patch ? If you don't have time maybe I'll give it a try...
Created attachment 32174 [details] [review] Updated patch. Here ya go :-)
I've updated the patch, it appears to work here (and does volume icons as well)
Comment on attachment 32174 [details] [review] Updated patch. I don't think we want to do anything which slows down the popup further, although icons would be a nice touch. Can we come up with an approach which loads the icons asynchronously ?
James: Have you investigated the async proposal? Sounds quiet reasonable.
Not at all. I can try to take a look at it, but I honestly doubt I'll have the time.
never happened, sadly