After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143130 - [mixmatrix] returns garbage pointer as request pad
[mixmatrix] returns garbage pointer as request pad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-05-25 14:39 UTC by Tim-Philipp Müller
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (893 bytes, patch)
2004-05-25 14:40 UTC, Tim-Philipp Müller
none Details | Review

Description Tim-Philipp Müller 2004-05-25 14:39:31 UTC
Mixmatrix returns random garbage pointers as request pads. Reproduce with: 
 
        mixmatrix = gst_element_factory_make ("mixmatrix", "mixmatrix"); 
        sinkpad = gst_element_get_request_pad (mixmatrix, "sink0"); 
        g_assert (GST_IS_PAD (sinkpad)); 
 
That's because the initial pads array is not initialised to NULL, so it just 
returns random garbage in the request pad function. 
 
Patch attached.  
 
There's more stuff that looks fishy to me, like: 
 
  mix->grpsize = 8; 
  mix->outsize = 1024; 
 
  // start with zero pads 
  mix->sinkpadalloc = mix->grpsize; 
  mix->srcpadalloc = mix->grpsize; 
 
but I couldn't be bothered to look into it further, as I found that I can't 
link the pads I get from deinterleave to the mixmatrix ones (the deinterleave 
pads have audio/x-raw-float caps with buffer-frames=(gint)0, and the mixmatrix 
request pads require buffer-frames >= 1). 
 
Cheers 
 -Tim
Comment 1 Tim-Philipp Müller 2004-05-25 14:40:38 UTC
Created attachment 28002 [details] [review]
patch
Comment 2 Tim-Philipp Müller 2004-06-21 18:06:42 UTC
This has been fixed ages ago (2004-06-07) - closing it. 
 
Cheers 
 -Tim