GNOME Bugzilla – Bug 143109
fish: output window of "fish command" is not resizing according to the fish label
Last modified: 2015-03-24 13:01:17 UTC
1) add command "ls" to the fish applet in the panel 1.1) right click over fish 1.2) take preference 1.3) type "ls" in the command to execute section 2)Enter the fish name as large as possible (>100 string length) 3)click over the fish applet button in the panel. Now the output window is resize to the string length. 4)again change the fish name to "sumesh" (any small string) 5)click over the fish applet button . Now the output window is not resizing. it remain as previous one. 6)if U logout the fish applet output window is resizing correctly.
the bugs on gnome aplet :fish
fish is part of gnome-panel. Moving to gnome-panel.
Created attachment 28075 [details] [review] Changes made to fish.c file. The function 'display_fortune_dialog()' updated The function 'display_fortune_dialog()' was not taking care for re-calculating the size of applet when the fish applet is already there and we change the name. It was doing so only if fish applet is not there. I updated that code in that function
Created attachment 28109 [details] [review] The patch takes care of situation where you re-name the fish and re-open using single click. This is the tested one patch which has been prepared using all standard convention for a patch. Because i m a newbie previously I didn`t followed conventions and sent the patch. Sorry for that.
Created attachment 28136 [details] [review] According to the instructions given by my NOSIP mentors i sorted out all the mistakes and prepared this patch. When fish applet is already there and we rename the fish, we have to apply the resizing functions. This patch takes care of this.
*** Bug 144217 has been marked as a duplicate of this bug. ***
Thanks for the patch, but I fixed this with ellipses: "make the "Wanda says" label ellipsized so the window doesn't grow forever when the name is long (fix bug #143109)