After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143102 - gThumb SHOULD save sizes when window is maximized
gThumb SHOULD save sizes when window is maximized
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.3.x
Other Linux
: High normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-05-25 03:50 UTC by Jason Tackaberry
Modified: 2005-01-12 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Removes the "if maximized" checks. (739 bytes, patch)
2004-05-25 15:36 UTC, Jason Tackaberry
none Details | Review

Description Jason Tackaberry 2004-05-25 03:50:04 UTC
Contrary to bug 114070, gThumb _should_ save sizes when the main window is
maximized.

In GNOME 2.6 (metacity 2.8), when an application requests a size equal to or
great than than what it would normally get when maximized, metacity seems to
maximize the window.  This seems acceptable, but with gthumb's current behaviour
of not saving size settings when maximized, it causes the following problem:

1. Open gthumb, and resize window to be as large or larger than it would be in a
maximzed state.  (This is possible by moving the top left corner of the window a
few pixels off the edge of the screen, and then resizing to fill the enter screen.)
2. Close gthumb.  Because the window is not technically maximized at this point,
gthumb will save the size of the window and the content panels.
3. Open gthumb.  It will request this new size, but the window manager will
simply maximize it.
4. Use gthumb and resize the sidebar panel and content pane.
5. Close gthumb.  It will not save the new size settings, even though the user
never explicitly maximized the window.

The main rationale for not saving settings when the window is maximized is that
when starting gthumb in maximized state, clicking unmaximize won't do anything
useful.  In fact, metacity 2.8 seems to do the right thing, and unmaximize the
window to some reasonable size.

I therefore suggest the changes made to fix bug 114070 are reverted.
Comment 1 Jason Tackaberry 2004-05-25 15:36:43 UTC
Created attachment 28004 [details] [review]
Removes the "if maximized" checks.

This removes the maximized check when closing down to cause gthumb to save
positioning info when its window is maximized.	Everything works just fine at
least with metacity 2.8.
Comment 2 Paolo Bacchilega 2005-01-12 18:07:58 UTC
fixed now, thank you.