After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142588 - [threads] if all elements have been removed from a bin, should it's state not be set to GST_STATE_NULL
[threads] if all elements have been removed from a bin, should it's state not...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 147000 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-15 18:14 UTC by Zaheer Abbas Merali
Modified: 2005-01-31 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Zaheer Abbas Merali 2004-05-15 18:14:52 UTC
I encountered a problem with a GstThread which I emptied during PAUSED state,
when I removed it from the main pipeline...the app core dumped due to freeing a
locked mutex.  The mutex gets unlocked during state change to NULL.  I tried
changing state to NULL before removing it from the main pipeline, but it didnt
change the state.  Ideally the gst_bin_remove should check if after removing, a
bin is empty and if it is it should change state to NULL.
Comment 1 Ronald Bultje 2005-01-29 23:50:29 UTC
*** Bug 147000 has been marked as a duplicate of this bug. ***
Comment 2 Ronald Bultje 2005-01-30 00:00:22 UTC
Zaheer, threadg passes with no problems here.

As for your original request, bins can have states independent of their
contained children. Bins can even be elements themselves. It's non-sensical to
change rules specifically for bins. I see your point, but I think they should be
able to be in a non-NULL state themselves. We have
gst_bin_synchronize_children_state() to get kids even.

If you agree, we can re-enable threadg and close this bug.
Comment 3 Ronald Bultje 2005-01-30 22:53:25 UTC
Hm, what I'm saying is crap, empty bins already set themselves to NULL state...
Ohwell, I stand corrected then. We should re-enable threadg (#123775 has a patch
to do that) and close this bug.
Comment 4 Ronald Bultje 2005-01-31 15:43:48 UTC
Done.