After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142552 - gnome-terminal 2.6.1 build fails with GCC 3.4.0
gnome-terminal 2.6.1 build fails with GCC 3.4.0
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.6.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-05-14 17:25 UTC by Adam Sampson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
Correct function definitions to match prototypes (837 bytes, patch)
2004-05-14 17:27 UTC, Adam Sampson 		none Details | Review

Description Adam Sampson 2004-05-14 17:25:47 UTC 
Description of Problem:
Building gnome-terminal 2.6.1 using GCC 3.4.0
fails owing to incorrect types.


Steps to reproduce the problem:
1. "./configure ; make"

Actual Results:
eggcellrendererkeys.c:588: error: conflicting
types for 'egg_cell_renderer_keys_set_accelerator'
eggcellrendererkeys.h:73: error: previous
declaration of
'egg_cell_renderer_keys_set_accelerator' was here
eggcellrendererkeys.c:588: error: conflicting
types for 'egg_cell_renderer_keys_set_accelerator'
eggcellrendererkeys.h:73: error: previous
declaration of
'egg_cell_renderer_keys_set_accelerator' was here
eggcellrendererkeys.c:630: error: conflicting
types for 'egg_cell_renderer_keys_get_accelerator'
eggcellrendererkeys.h:76: error: previous
declaration of
'egg_cell_renderer_keys_get_accelerator' was here
eggcellrendererkeys.c:630: error: conflicting
types for 'egg_cell_renderer_keys_get_accelerator'
eggcellrendererkeys.h:76: error: previous
declaration of
'egg_cell_renderer_keys_get_accelerator' was here


Expected Results:
<nothing>


How often does this happen? 
Every time.


Additional Information:
Changing GdkModifierType to EggVirtualModifierType
in those two declarations fixes it for me. Patch
attached.
Comment 1 Adam Sampson 2004-05-14 17:27:00 UTC 
Created attachment 27708 [details] [review]
Correct function definitions to match prototypes

This fix is of the "works for me" variety; it may be preferable to fix the
header file instead.
Comment 2 Mariano Suárez-Alvarez 2004-06-05 00:16:10 UTC 
This was FIXED on HEAD. I've just applied the patch to the 2.6 branch.

Thanks!
Comment 3 Stef van der Made 2004-06-06 13:49:01 UTC 
Confirmed fixed by downloading CVS version of source file.

Thanks for fixing this issue