After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142544 - Incompatible coordinate systems between OTL and PangoGlyphGeometry
Incompatible coordinate systems between OTL and PangoGlyphGeometry
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.4.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks: 141541
 
 
Reported: 2004-05-14 13:55 UTC by Theppitak Karoonboonyanan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
A proposed patch (799 bytes, patch)
2004-05-14 13:59 UTC, Theppitak Karoonboonyanan
accepted-commit_now Details | Review

Description Theppitak Karoonboonyanan 2004-05-14 13:55:45 UTC
As part of adding OpenType support in Pango Thai module, I find some wierdness
of GPOS glyph positioning as described in Bug #141541, Comment #4, issue 2.
After trying moving the anchors around, I find the effect of the movement as
rendered by Pango becomes in opposite direction, e.g. when I move base anchor
up, the mark gets shifted down.

This makes me think there must be something wrong in Pango/FreeType, because the
font data is all OK when dumped with Fonttools/ttx.

One smell I gets is that the OTL_PositionRec uses coordinate system in which Y
increases in up direction, while PangoGlyphGeometry may be using screen
coordinate, in which Y grows down the screen.
Comment 1 Theppitak Karoonboonyanan 2004-05-14 13:59:33 UTC
Created attachment 27700 [details] [review]
A proposed patch

With this patch applied, the patch proposed in Bug #141541 just gives the
desired result.
Comment 2 Theppitak Karoonboonyanan 2004-05-14 14:03:47 UTC
Add PATCH keyword, and dependency from Bug #141541
Comment 3 Owen Taylor 2004-05-27 18:08:33 UTC
Comment on attachment 27700 [details] [review]
A proposed patch

Looks good - the exact same fix was done for bug 132591, but lost with the
coversion to PangoOTBuffer.
Comment 4 Theppitak Karoonboonyanan 2004-05-28 16:46:20 UTC
Patch committed to HEAD and pango-1-4 branch.

Fri May 28 2004  Theppitak Karoonboonyanan  <thep@linux.thai.net>

        * pango/opentype/pango-ot-buffer.c (apply_gpos_ltr): Negate y offset
        according to different conventions between PangoGlyphString and OTL
        (#142544)