GNOME Bugzilla – Bug 142544
Incompatible coordinate systems between OTL and PangoGlyphGeometry
Last modified: 2004-12-22 21:47:04 UTC
As part of adding OpenType support in Pango Thai module, I find some wierdness of GPOS glyph positioning as described in Bug #141541, Comment #4, issue 2. After trying moving the anchors around, I find the effect of the movement as rendered by Pango becomes in opposite direction, e.g. when I move base anchor up, the mark gets shifted down. This makes me think there must be something wrong in Pango/FreeType, because the font data is all OK when dumped with Fonttools/ttx. One smell I gets is that the OTL_PositionRec uses coordinate system in which Y increases in up direction, while PangoGlyphGeometry may be using screen coordinate, in which Y grows down the screen.
Created attachment 27700 [details] [review] A proposed patch With this patch applied, the patch proposed in Bug #141541 just gives the desired result.
Add PATCH keyword, and dependency from Bug #141541
Comment on attachment 27700 [details] [review] A proposed patch Looks good - the exact same fix was done for bug 132591, but lost with the coversion to PangoOTBuffer.
Patch committed to HEAD and pango-1-4 branch. Fri May 28 2004 Theppitak Karoonboonyanan <thep@linux.thai.net> * pango/opentype/pango-ot-buffer.c (apply_gpos_ltr): Negate y offset according to different conventions between PangoGlyphString and OTL (#142544)