After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142507 - [PATCH] id3tag plugin does not correctly set buffer offset
[PATCH] id3tag plugin does not correctly set buffer offset
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-05-14 02:18 UTC by David Moore
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
Patch to manually set buffer offset (508 bytes, patch)
2004-05-14 02:20 UTC, David Moore 		none Details | Review

Description David Moore 2004-05-14 02:18:15 UTC 
gstid3tag.c falsely assumes that gst_buffer_create_sub() will set the offset
field of the created buffer.  This is not the case, as decided in bug 113180,
since the offset field is media specific.  Thus, gstid3tag.c really ought to set
the buffer offset manually after running gst_buffer_create_sub() with a non-zero
offset.

This bug manifests itself in this way:  If the pipeline is not seekable (such as
with fdsrc) and the played mp3 has an ID3v2 tag at the beginning, the first
second or two of audio will be skipped.
Comment 1 David Moore 2004-05-14 02:20:14 UTC 
Created attachment 27681 [details] [review]
Patch to manually set buffer offset

The attached one-liner patch fixes the bug by setting the buffer offset
manually following the call to gst_buffer_create_sub().
Comment 2 Benjamin Otte (Company) 2004-05-17 00:25:31 UTC 
fixed in cvs