GNOME Bugzilla – Bug 142366
Solve funny interaction between gtk_clipboard_wait_is_text_available and window sizing.
Last modified: 2004-12-22 21:47:04 UTC
Details follow.
(I needed a bug number to do the commit...) Ok. If you revert this patch, and open a window, make it bigger and open another tab, the window will be resized back to 80x24. This is triggered by the fact that update_copy_sensitivity calls gtk_clipboard_wait_is_text_available, which does stuff on the main loop, so somehow the vte widget gets a chance to set its size before the sane one kicks in. Index: src/terminal-window.c =================================================================== RCS file: /cvs/gnome/gnome-terminal/src/terminal-window.c,v retrieving revision 1.92 retrieving revision 1.93 diff -U5 -r1.92 -r1.93 --- src/terminal-window.c 11 May 2004 16:46:58 -0000 1.92 +++ src/terminal-window.c 11 May 2004 20:12:59 -0000 1.93 @@ -1691,21 +1691,21 @@ } gdk_window_set_icon_name (GTK_WIDGET (window)->window, terminal_screen_get_icon_title (screen)); gtk_window_set_title (GTK_WINDOW (window), terminal_screen_get_title (screen)); - update_copy_sensitivity (window); - gtk_notebook_set_current_page (GTK_NOTEBOOK (window->priv->notebook), gtk_notebook_page_num (GTK_NOTEBOOK (window->priv->notebook), screen_get_hbox (screen))); /* set size of window to current grid size */ #ifdef DEBUG_GEOMETRY g_print ("setting size after flipping notebook pages\n"); #endif terminal_window_set_size (window, screen, TRUE); + + update_copy_sensitivity (window); fill_in_config_picker_submenu (window); fill_in_new_term_submenus (window); update_zoom_items (window); }
All calls to gtk_clipboard_wait_is_text_available have been banished, so this is no longer relevant.