After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142366 - Solve funny interaction between gtk_clipboard_wait_is_text_available and window sizing.
Solve funny interaction between gtk_clipboard_wait_is_text_available and wind...
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-05-11 20:03 UTC by Mariano Suárez-Alvarez
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Mariano Suárez-Alvarez 2004-05-11 20:03:12 UTC
Details follow.
Comment 1 Mariano Suárez-Alvarez 2004-05-11 20:16:55 UTC
(I needed a bug number to do the commit...)

Ok. If you revert this patch, and open a window, make it bigger and open another
tab, the window will be resized back to 80x24.
This is triggered by the fact that update_copy_sensitivity calls
gtk_clipboard_wait_is_text_available, which does stuff on the main loop, so
somehow the vte widget gets a chance to set its size before the sane one kicks in. 


Index: src/terminal-window.c
===================================================================
RCS file: /cvs/gnome/gnome-terminal/src/terminal-window.c,v
retrieving revision 1.92
retrieving revision 1.93
diff -U5 -r1.92 -r1.93
--- src/terminal-window.c       11 May 2004 16:46:58 -0000      1.92
+++ src/terminal-window.c       11 May 2004 20:12:59 -0000      1.93
@@ -1691,21 +1691,21 @@
     }

   gdk_window_set_icon_name (GTK_WIDGET (window)->window,
terminal_screen_get_icon_title (screen));
   gtk_window_set_title (GTK_WINDOW (window), terminal_screen_get_title (screen));

-  update_copy_sensitivity (window);
-
   gtk_notebook_set_current_page (GTK_NOTEBOOK (window->priv->notebook),
                                  gtk_notebook_page_num (GTK_NOTEBOOK
(window->priv->notebook),
                                                         screen_get_hbox (screen)));

   /* set size of window to current grid size */
 #ifdef DEBUG_GEOMETRY
   g_print ("setting size after flipping notebook pages\n");
 #endif
   terminal_window_set_size (window, screen, TRUE);
+
+  update_copy_sensitivity (window);

   fill_in_config_picker_submenu (window);
   fill_in_new_term_submenus (window);
   update_zoom_items (window);
 }
Comment 2 Mariano Suárez-Alvarez 2004-11-23 06:09:36 UTC
All calls to gtk_clipboard_wait_is_text_available have been banished, so this is
no longer relevant.