GNOME Bugzilla – Bug 142338
remove duplicated code between glib/libgnome and vicious-extensions
Last modified: 2005-10-28 20:31:17 UTC
ve_setenv and ve_unsetenv are in glib now (and libgnome), and ve_clearenv is in libgnome, so gdm should use those rather than duplicating the code. (In particular because gnome_clearenv/ve_clearenv doesn't compile correctly on OS X and I only want to have to fix it in once place.)
Created attachment 27599 [details] [review] patch to use g_setenv/g_unsetenv/gnome_clearenv
ve is used even without libgnome, thus must use ve_clearenv. gdm doesn't use libgnome, and I won't link it in just for clearenv. Thus this is a WONTFIX. Feel free to provide the patch that fixes ve_clearenv on OS X. Also if you note in the code ve_setenv/ve_unsetenv are just defines for g_setenv/g_unsetenv when new enough glib is found. GDM is compiled with new glib, but genius might not and ve is also used there.
I see that vicious-extensions relies on libgnome. If not, why is this in configure? PKG_CHECK_MODULES(VICIOUS, gtk+-2.0 >= $GTK_REQUIRED libglade-2.0 >= $LIBGLADE_R EQUIRED libgnome-2.0 >= $LIBGNOME_REQUIRED)
Yes, we need to get rid of libgnome in vicious-extensions. The only place it is used is the four places ve-gnome.c calls gnome_program_locate_file(). Is there a better recommended interface to use here? I assume so.