After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142316 - Add read/extract support for iso files
Add read/extract support for iso files
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.6.x
Other Linux
: Normal enhancement
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-05-11 02:39 UTC by Daniel Brodie
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
Preliminary Patch (3.96 KB, application/x-bzip)
2004-05-11 02:40 UTC, Daniel Brodie 		  Details
Final iso patch (6.09 KB, patch)
2004-05-24 16:44 UTC, Daniel Brodie 		none Details | Review
Additional files for patch (1.97 KB, text/x-chdr)
2004-05-24 16:45 UTC, Daniel Brodie 		  Details
Additional files for patch (6.05 KB, text/x-csrc)
2004-05-24 16:45 UTC, Daniel Brodie 		  Details

Description Daniel Brodie 2004-05-11 02:39:58 UTC 
Attached is a preliminary patch to add support for viewing and extracting iso
files. The only missing part is the make_hierarchy function to allow extraction
of files in subfolders. Also, there are probably some more parts in the code
where the mime type should be added that I didn't add it to (pointers to these
would be nice).
Comment 1 Daniel Brodie 2004-05-11 02:40:49 UTC 
Created attachment 27579 [details]
Preliminary Patch
Comment 2 Daniel Brodie 2004-05-24 16:44:14 UTC 
Created attachment 27978 [details] [review]
Final iso patch

This patch fully implements reading and extracting files from iso images
Comment 3 Daniel Brodie 2004-05-24 16:45:07 UTC 
Created attachment 27979 [details]
Additional files for patch
Comment 4 Daniel Brodie 2004-05-24 16:45:47 UTC 
Created attachment 27980 [details]
Additional files for patch
Comment 5 Daniel Brodie 2004-05-24 16:48:35 UTC 
Adding patch keyword
Comment 6 Paolo Bacchilega 2004-05-27 13:39:49 UTC 
The patch is very good, I've now committed it to the CVS,

thank you.

P.S.
It seems that you forgot to define the maktime_from_string function, however
looking at the output of isoinfo I noticed it uses the same format used by rpm
so I used the mktime_from_string function defined in fr-command-rpm.c and seems
to work ok, is this correct?
Comment 7 Daniel Brodie 2004-05-27 17:11:05 UTC 
Whoops. When I was cleaning up the patch I accidentally deleted that function.
Yeah it was supposed to be the mktime_from_string from the rpm command (since I
based the patch from the rpm command files).

Thanks!