After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142272 - [PATCH] [qtdemux] doesn't work with sources that cannot seek
[PATCH] [qtdemux] doesn't work with sources that cannot seek
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.1
Other Linux
: Normal normal
: 0.8.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-05-10 13:50 UTC by David Moore
Modified: 2005-01-29 12:54 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
Patch to qtdemux to support sources that can't seek (3.09 KB, patch)
2004-05-10 13:53 UTC, David Moore 		none Details | Review
qtdemux-seek-fix.patch (3.23 KB, patch)
2005-01-24 15:52 UTC, Daniel Drake 		none Details | Review

Description David Moore 2004-05-10 13:50:08 UTC 
1. Create this (or a similar) pipeline: fdsrc ! qtdemux ! faad ! osssink

2. Pipe an m4a file through the fd

3. qtdemux fails to detect the data stream as an audio file

What should happen:  qtdemux should generate an audio_00 pad and push data to
the faad decoder.

Why it doesn't work:  qtdemux seeks the incoming stream, but fdsrc does provide
a seek function.
Comment 1 David Moore 2004-05-10 13:53:38 UTC 
Created attachment 27542 [details] [review]
Patch to qtdemux to support sources that can't seek

Attached is a patch to the latest CVS version of qtdemux that uses
gst_bytestream_flush() when gst_bytestream_seek() fails.  This allows
non-seeking sources to play correctly.
Comment 2 David Schleef 2004-05-19 06:29:49 UTC 
Applied, thanks.
Comment 3 Daniel Drake 2005-01-24 15:52:10 UTC 
It seems that the above patch got reverted soon after it was committed:

http://cvs.freedesktop.org/gstreamer/gst-plugins/gst/qtdemux/qtdemux.c?r1=1.64&r2=1.65
(CVS comment this time was "Fix seeking, add SVQ3 format")

This prevents me from playing m4a files over a stream.
I rediffed the patch posted here against gst-plugins-0.8.7 and now my streaming
works. I also used totem to test playing these files locally, and seeking still
works.
Comment 4 Daniel Drake 2005-01-24 15:52:45 UTC 
Created attachment 36457 [details] [review]
qtdemux-seek-fix.patch

The rediffed patch
Comment 5 Ronald Bultje 2005-01-29 12:54:58 UTC 
Seems to work for me too, don't know why I reverted earlier...