After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141931 - Incorrect casts in pango_break()
Incorrect casts in pango_break()
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.4.x
Other Linux
: High critical
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2004-05-05 16:42 UTC by Theppitak Karoonboonyanan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
Proposed patch (1016 bytes, patch)
2004-05-05 16:43 UTC, Theppitak Karoonboonyanan 		accepted-commit_now Details | Review

Description Theppitak Karoonboonyanan 2004-05-05 16:42:01 UTC 
When calling language engine's script_break() function in pango_break(), the
casts to get the class of analysis->lang_engine object are the wrong ones. So,
if there is any language engine registered, this usually crashes applications
(segfault). And this is considered a regression from previous version.
Comment 1 Theppitak Karoonboonyanan 2004-05-05 16:43:02 UTC 
Created attachment 27398 [details] [review]
Proposed patch
Comment 2 Theppitak Karoonboonyanan 2004-05-05 16:43:52 UTC 
Add PATCH keyword.
Comment 3 Owen Taylor 2004-05-06 14:05:48 UTC 
Comment on attachment 27398 [details] [review]
Proposed patch

Looks good to commit
Comment 4 Theppitak Karoonboonyanan 2004-05-06 16:56:23 UTC 
Patch committed.

--- ChangeLog   29 Apr 2004 09:57:49 -0000      1.881
+++ ChangeLog   6 May 2004 16:48:03 -0000
@@ -1,3 +1,8 @@
+2004-05-06  Theppitak Karoonboonyanan  <thep@linux.thai.net>
+
+       * pango/break.c (pango_break):
+       Fix incorrect casts to get the class object of lang engine. (#141931)
+
 2004-04-29  Tor Lillqvist  <tml@iki.fi>

        * pango/pangowin32-fontmap.c (pango_win32_font_map_for_display):