After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141667 - Egg recent view that uses the ui manager
Egg recent view that uses the ui manager
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: recent-files
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: James Willcox
James Willcox
Depends on:
Blocks:
 
 
Reported: 2004-05-02 19:01 UTC by Paolo Bacchilega
Modified: 2005-03-30 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
this is the c file. (18.49 KB, patch)
2004-05-02 19:03 UTC, Paolo Bacchilega
none Details | Review
the header (3.19 KB, patch)
2004-05-02 19:03 UTC, Paolo Bacchilega
none Details | Review
support multiple EggRecentViewUIManager (1.32 KB, patch)
2004-07-27 06:54 UTC, David A Knight
none Details | Review
revised to use merge_id (3.56 KB, patch)
2004-07-27 08:03 UTC, David A Knight
none Details | Review

Description Paolo Bacchilega 2004-05-02 19:01:35 UTC
I've done a egg recent view that uses the ui manager interface to create the
menu items.
Comment 1 Paolo Bacchilega 2004-05-02 19:03:17 UTC
Created attachment 27309 [details] [review]
this is the c file.
Comment 2 Paolo Bacchilega 2004-05-02 19:03:49 UTC
Created attachment 27310 [details] [review]
the header
Comment 3 David A Knight 2004-07-27 06:54:05 UTC
Created attachment 29924 [details] [review]
support multiple EggRecentViewUIManager

As it stands the attached EggRecentViewUIManager is limited to 1 per app
(screem keeps 2 lists, 1 for projects, 1 for files worked on outside of a
project).  This patch allows multiple instances, and also simplifies
egg_recent_view_uimanager_get_item() to get the item via g_object_get_data() on
the GtkAction.
Comment 4 David A Knight 2004-07-27 08:03:34 UTC
Created attachment 29927 [details] [review]
revised to use merge_id

same patch revised to use the obtained merge_id as the unique group identifier.


removes view->item_list, not needed as items can be obtained directly from
actions anyway, this also fixes a crash as already destroyed EggRecentItems
were being unrefed here.

make trailing sep names contain the merge_id as well
Comment 5 Paolo Borelli 2005-03-30 16:48:23 UTC
After asking snorp on IRC I committed the latest version of Paolo Bacchilega's
uimanager view and a small test app.

I'm leaving the bug open since I have no idea about the status of David's
patches attached to this bug: the version I committed is the latest found in
File Roller and used in many other projects. I'll leave to Paolo Bacchilega any
other decision about changes to egg-recent-view-uimanager.
Comment 6 Paolo Bacchilega 2005-03-30 19:53:04 UTC
David's patch has been applied now, closing the bug...