After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141405 - PangoLayout alignments are reversed when context uses WEAK_*
PangoLayout alignments are reversed when context uses WEAK_*
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.5.x
Other other
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2004-04-29 16:35 UTC by Jody Goldberg
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make the comparison a bit smarter (1.52 KB, patch)
2004-04-29 16:38 UTC, Jody Goldberg 		accepted-commit_now Details | Review
version that was committed (3.71 KB, patch)
2004-05-28 19:24 UTC, Jody Goldberg 		none Details | Review

Description Jody Goldberg 2004-04-29 16:35:11 UTC 
As discussed the get_alignment routine was a bit too literal.
The attached patch would seem to solve that.
Comment 1 Jody Goldberg 2004-04-29 16:38:23 UTC 
Created attachment 27210 [details] [review]
make the comparison a bit smarter

I'm guessing that neutral shouldn't invert
Comment 2 Owen Taylor 2004-05-27 17:29:40 UTC 
Looks good to commit if you rename the function to something like
get_simple_direction (), and add a space after the '-'.

[I don't like having static functions that look like they are global API
functions in a different module]

I haven't branched yet, so you just need to commit on HEAD.
Comment 3 Owen Taylor 2004-05-27 19:09:29 UTC 
Actually, now I've branched, so this needs to be committed both on
pango-1-4 and HEAD.
Comment 4 Jody Goldberg 2004-05-28 19:24:24 UTC 
Created attachment 28129 [details] [review]
version that was committed

This variant was committed to head and pango-1-4