GNOME Bugzilla – Bug 141032
Filter Pack plug-in: Repeat filter shows dialog iso directly repeating filter
Last modified: 2005-08-15 11:54:31 UTC
After applying the Filter Pack plug-in Ctrl+F (Repeat last filter) will bring up the dialog again instead of directly applying the filter.
I'll fix this one myself and try to clean up this plug-in a bit.
Code is currently kind of a mess. It's almost randomly distributed over 4 different files with each and every function and variable declared globally in one single header file. I think I will first put all the code in one single file (it's not that much anyway), clean it up, and then later split it up over different files again if needed.
It would be nice to get this bug fixed. Of course a code cleanup would be nice as well, but perhaps just the bugfix for now?
Adding Maurits to the Cc: so that he gets my comments. He is unfortunately not on the bugs@gimp.org mail alias :(
Maurits, is this still on your TODO? Can we expect a fix for 2.2?
I probably won't fix this for 2.2. My priorities right now are 1) fixing severe Imagemap bugs and 2) getting my Gimp# project in shape for general consumption.
It is still a problem that should be fixed for 2.2. If you do it or not isn't relevant. Moving back to the 2.2 milestone.
I have set the milestone to Future because this is (compared to othter bugs) only a minor annoyance. Of course this should be fixed, but imo this isn't holding back 2.2. Having a 2.2.1 and maybe even a 2.3 target milestone would help assigning bugs more accurately than just setting them to `Future'. Just a thought.
That is true for almost all bugs on the 2.2 milestone and of course we will have to move most of them to Future in a couple of days. But at the moment this bug is on the 2.2 milestone to draw people's attention to it.
A look at the code shows that this is highly nontrivial, because Filter Pack does not come anywhere close to following the standard plug-in logic -- it doesn't use get/set_data(), and does all its work in its dialog. It would really be a major rewrite to get this to work, and probably not even appropriate for 2.2. Of course, popping a message saying that the filter can't be automatically repeated would be a lot easier.
removing this bug from the 2.2 milestone then
Could use some ui improvement, but the problem this report is about seems fixed. Would take some work to backport to 2.2, probably. For cvs HEAD: 2005-03-17 Bill Skaggs <weskaggs@primate.ucdavis.edu> * plug-ins/common/fp.c: major code cleanup, make it Repeat and Re-Show properly. Should fix bug #141032.
Setting milestone to 2.4 so that this report shows up in the list of bugs fixed with 2.4.
2005-08-15 Sven Neumann <sven@gimp.org> * plug-ins/common/fp.c: merged fixes for bug #160032 and bug #141032 from HEAD branch.