After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141032 - Filter Pack plug-in: Repeat filter shows dialog iso directly repeating filter
Filter Pack plug-in: Repeat filter shows dialog iso directly repeating filter
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Linux
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-04-24 19:50 UTC by Maurits Rijk
Modified: 2005-08-15 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Maurits Rijk 2004-04-24 19:50:31 UTC
After applying the Filter Pack plug-in Ctrl+F (Repeat last filter) will bring up
the dialog again instead of directly applying the filter.
Comment 1 Maurits Rijk 2004-04-24 20:06:39 UTC
I'll fix this one myself and try to clean up this plug-in a bit.
Comment 2 Maurits Rijk 2004-04-25 19:01:09 UTC
Code is currently kind of a mess. It's almost randomly distributed over 4
different files with each and every function and variable declared globally in
one single header file. I think I will first put all the code in one single file
(it's not that much anyway), clean it up, and then later split it up over
different files again if needed.
Comment 3 Sven Neumann 2004-09-24 10:26:49 UTC
It would be nice to get this bug fixed. Of course a code cleanup would be nice
as well, but perhaps just the bugfix for now?
Comment 4 Sven Neumann 2004-10-06 12:20:37 UTC
Adding Maurits to the Cc: so that he gets my comments. He is unfortunately not
on the bugs@gimp.org mail alias :(
Comment 5 Sven Neumann 2004-10-22 15:47:59 UTC
Maurits, is this still on your TODO? Can we expect a fix for 2.2?
Comment 6 Maurits Rijk 2004-10-27 09:51:58 UTC
I probably won't fix this for 2.2. My priorities right now are 1) fixing severe
Imagemap bugs and 2) getting my Gimp# project in shape for general consumption.
Comment 7 Sven Neumann 2004-10-27 10:40:09 UTC
It is still a problem that should be fixed for 2.2. If you do it or not isn't
relevant. Moving back to the 2.2 milestone.
Comment 8 Maurits Rijk 2004-10-27 14:47:43 UTC
I have set the milestone to Future because this is (compared to othter bugs)
only a minor annoyance. Of course this should be fixed, but imo this isn't
holding back 2.2. Having a 2.2.1 and maybe even a 2.3 target milestone would
help assigning bugs more accurately than just setting them to `Future'. Just a
thought.
Comment 9 Sven Neumann 2004-10-27 16:01:40 UTC
That is true for almost all bugs on the 2.2 milestone and of course we will have
to move most of them to Future in a couple of days. But at the moment this bug
is on the 2.2 milestone to draw people's attention to it.
Comment 10 weskaggs 2004-12-11 15:47:07 UTC
A look at the code shows that this is highly nontrivial, because Filter Pack
does not come anywhere close to following the standard plug-in logic -- it
doesn't use get/set_data(), and does all its work in its dialog.  It would
really be a major rewrite to get this to work, and probably not even appropriate
for 2.2.  

Of course, popping a message saying that the filter can't be automatically
repeated would be a lot easier.
Comment 11 Sven Neumann 2004-12-12 14:37:13 UTC
removing this bug from the 2.2 milestone then
Comment 12 weskaggs 2005-03-17 22:53:19 UTC
Could use some ui improvement, but the problem this report is about seems fixed.
 Would take some work to backport to 2.2, probably.

For cvs HEAD:

2005-03-17  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/fp.c:  major code cleanup, make it
	Repeat and Re-Show properly.  Should fix bug #141032.
Comment 13 Sven Neumann 2005-03-17 23:45:40 UTC
Setting milestone to 2.4 so that this report shows up in the list of bugs fixed
with 2.4.
Comment 14 Sven Neumann 2005-08-15 11:54:31 UTC
2005-08-15  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/fp.c: merged fixes for bug #160032 and bug
	#141032 from HEAD branch.