After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140776 - 'Show Desktop' button doesn't react on icon theme changes
'Show Desktop' button doesn't react on icon theme changes
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: show-desktop-button
git master
Other All
: Normal major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
AP2
Depends on:
Blocks:
 
 
Reported: 2004-04-21 20:11 UTC by Patrick Wade
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (4.31 KB, patch)
2005-01-18 22:28 UTC, Paolo Borelli 		none Details | Review

Description Patrick Wade 2004-04-21 20:11:26 UTC 
Running GNOME built using gnome-panel-2.6.0-7 source tarball:


-Change the theme to High Contrast Large Print Inverse
-Ensure the 'show desktop' button is added to the panel

See that the button does not theme for such a11y-related GNOME themes.
It needs to have icons as follows:

High Contrast
High Contrast Inverse
Low Contrast
Low Contrast Inverse
Comment 1 Mark McLoughlin 2004-04-22 10:53:29 UTC 
where do icons go ?

icon name: gnome-fs-desktop
Comment 2 Calum Benson 2004-04-23 16:09:29 UTC 
Should just need to add an appropriate version to each of:

gnome-themes/HighContrastLargePrint/icons/48x48/filesystems
gnome-themes/HighContrastLargePrintInverse/icons/48x48/filesystems
gnome-themes/LowContrastLargePrint/icons/48x48/filesystems
Comment 3 John Crawley 2004-07-26 09:44:01 UTC 
This now has a High Contrast/High Contrast inverse icon. However, the change
doesnt come into effect until the user logs out and logs back in again.
Comment 4 Calum Benson 2004-07-26 13:45:05 UTC 
That sounds like a gnome-panel bug, then-- reassigning.
Comment 5 Christian Neumair 2004-10-21 14:18:37 UTC 
Indeed, this is a panel issue. applets/wncklet/showdesktop.c should react on
icon theme changes.
Comment 6 Calum Benson 2004-10-21 16:53:25 UTC 
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 7 Vincent Untz 2005-01-12 13:57:55 UTC 
Sorry for the spam. Mass-marking some bugs to the 2.10.x milestone.
 Filter on "VINCENT WANTS THIS FOR 2.10" to ignore.
Comment 8 Paolo Borelli 2005-01-18 22:28:25 UTC 
Created attachment 36218 [details] [review]
proposed patch

The patch fixes the reported issue by porting the applet from GnomeIconTheme to
GtkIconTheme and connecting to the theme-changed signal: each time the icon is
updated (either because of a theme change or because of a size change etc) the
old pixbuf is unrefed and a new one is retrieved from the theme.
Comment 9 Paolo Borelli 2005-01-25 18:48:06 UTC 
I somewhat hoped for this patch to get into 2.9.90 since marked mileston is set
to 2.10... anyway, before I forget, the above patch has two minor issues:
- it duplicates an include
- it unref the GtkIconTheme... this has not caused problem when I tested, but I
was told it isn't necessary
Comment 10 Vincent Untz 2005-01-25 19:25:19 UTC 
Paolo: sorry for not getting this in in 2.9.90. I have been pretty busy these
last few days, so I couldn't review anything. I just made the release... It'll
probably go for the next release since it's in my TODO list :-)
Comment 11 Vincent Untz 2005-01-29 01:07:36 UTC 
I committed a modified version of your patch so that it works well on
multiscreen environment.