After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140265 - ffmpegcolorspace and gnomevfs fail to build buildable
ffmpegcolorspace and gnomevfs fail to build buildable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other other
: Normal normal
: 0.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-04-16 14:36 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
Proposed patch (1.42 KB, patch)
2004-04-16 14:38 UTC, Julio Merino 		none Details | Review

Description Julio Merino 2004-04-16 14:36:39 UTC 
The ffmpegcolorspace and gnomevfs plugins do not build correctly under NetBSD,
because they use the GST_ELEMENT_ERROR macro incorrectly.  (Unfortunately, this
is the third time I hit this problem...)

The bug is that they pass a NULL value without parenthesis around.  Due to the
way NULL is defined in NetBSD, (void *)0, and the way the macro works, the build
fails because of a parsing error.

For more information, see bug #135116, which was about the same problem.
Comment 1 Julio Merino 2004-04-16 14:38:32 UTC 
Created attachment 26720 [details] [review]
Proposed patch

This patch just parenthesises NULL arguments in calls to GST_ELEMENT_ERROR, as
I was once told that this is the right fix.
Comment 2 David Schleef 2004-04-16 23:38:14 UTC 
This has already been fixed in CVS.