GNOME Bugzilla – Bug 140001
Recently used document History deletion option
Last modified: 2005-10-31 21:30:10 UTC
Please consider adding an option to Preferences to allow for choosing to have the History of recently used documents deleted whenever the GIMP is closed (for the sake of privacy).
If you do not want the recently used documents to be visible, you can go to Preferences->Interface and set Menus / Open Recent Menu Size to 0. Alternatively, you can delete the file ~/.gimp-2.0/documents when you exit. Adding an option to clear the list of recently used documents could be interesting but keep in mind that the user-specific files are not supposed to be shared between users (i.e., each user should have his/her own account with a separate copy of the .gimp-2.0 personal files) so I do not expect this new feature to have a high priority.
>If you do not want the recently used documents to be visible, you can go to Preferences->Interface and set Menus / Open Recent Menu Size to 0. This doesn't seem to work at all. I'd already tried it. Even after changing it to "0" documents continue to accumulate in the recent document history. >Alternatively, you can delete the file ~/.gimp-2.0/documents when you exit. Yes, thank you. I've already been doing this by adding it to my WindowWasher's list of files to clean up when I exit Windows. I just thought it might be nice for applications to offer in-program alternatives to deleting their own left- over lists. >Adding an option to clear the list of recently used documents could be interesting but . . . I do not expect this new feature to have a high priority. OK. Thanks, anyway. And thanks for a really cool application.
Setting a few target milestones now that 2.2 is coming closer.
This can easily be done by copying some code from the "Reset all tool options" stuff. Optimistically setting to 2.4.
Do we really want to have this in the Preferences or should there rather be a "Delete document history" entry been added to the bottom of the Recently Used file menu? And to the Images dock, of course?
If the goal is to protect the user's privacy on shared computers (especially for Windows users having only one account on their machine) then it would make more sense to have an option that allows an automatic clean-up on exit as the reporter suggested. Requiring an explict action from the user would not be such a big improvement over the manual deletion of the recent documents file. So an option in the Preferences would be better (maybe in addition to an explicit Delete entry in the appropriate places). Recent browsers and other applications offer such an option. I suppose that it is very valuable for those who do not want to reveal the location of their pr0n collection...
I suggest that we just add a "Clear" button to the Document History dialog and postpone the other change until the new recent-documents spec, that Emmanuele Bassis is working on, is finished. (see the discussion on desktop-devel list and http://live.gnome.org/RecentFilesAndBookmarks). That will most probably allow us to get rid of our own document history file and will push the problem to the desktop environment.
Added the "Clear" button. Does this count as FIXED now? 2005-06-20 Michael Natterer <mitch@gimp.org> * app/actions/documents-actions.c * app/actions/documents-commands.[ch] * app/widgets/gimphelp-ids.h * menus/documents-menu.xml: added "Clear document history" action, button, menu item and confirm dialog (bug #140001).
I think we still need a preference option that allows to disable use of the ~/.recently-used file. That should be pretty easy to add.
*** Bug 319466 has been marked as a duplicate of this bug. ***
Created attachment 54105 [details] [review] patch for bug #140001 Here is my patch. Added a option in the preference dialog to choose to save or not save into document history.
Created attachment 54128 [details] [review] improved patch basically the same but now you still get the list of files you have edited during the session unti closed and using gimpcoreconfig instead of gimpguiconfig.
Created attachment 54129 [details] [review] improved patch basically the same but now you still get the list of files you have edited during the session unti closed and using gimpcoreconfig instead of gimpguiconfig.
Patch looks good apart from some minor stylistic issues. Will fix them when comitting.
Fixed in CVS: 2005-10-31 Michael Natterer <mitch@gimp.org> Applied modified patch from Luis de Bethencourt Guimera which adds a "Save document history" prefs option. Fixes bug #140001. * app/config/gimprc-blurbs.h * app/config/gimpcoreconfig.[ch]: added boolean property "save-document-hitory". * app/core/gimp.c * app/file/file-open.c * app/file/file-save.c: don't save the document history and don't add files to the desktop-wide list of recently used files if the option is FALSE. * app/dialogs/preferences-dialog.c: added its toggle to the "Environment" page.
Created attachment 54162 [details] [review] actually comitted patch