After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140001 - Recently used document History deletion option
Recently used document History deletion option
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Low enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 319466 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-04-14 04:54 UTC by Daze N. Knights
Modified: 2005-10-31 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for bug #140001 (13.99 KB, patch)
2005-10-31 00:28 UTC, Luis de Bethencourt Guimera
rejected Details | Review
improved patch (15.75 KB, patch)
2005-10-31 13:51 UTC, Luis de Bethencourt Guimera
rejected Details | Review
improved patch (15.75 KB, patch)
2005-10-31 13:51 UTC, Luis de Bethencourt Guimera
committed Details | Review
actually comitted patch (6.25 KB, patch)
2005-10-31 21:30 UTC, Michael Natterer
none Details | Review

Description Daze N. Knights 2004-04-14 04:54:18 UTC
Please consider adding an option to Preferences to allow for choosing to have 
the History of recently used documents deleted whenever the GIMP is closed (for 
the sake of privacy).
Comment 1 Raphaël Quinet 2004-04-14 06:54:05 UTC
If you do not want the recently used documents to be visible, you can go to
Preferences->Interface and set Menus / Open Recent Menu Size to 0.  Alternatively,
you can delete the file ~/.gimp-2.0/documents when you exit.

Adding an option to clear the list of recently used documents could be interesting
but keep in mind that the user-specific files are not supposed to be shared
between users (i.e., each user should have his/her own account with a separate
copy of the .gimp-2.0 personal files) so I do not expect this new feature to have
a high priority.
Comment 2 Daze N. Knights 2004-04-14 16:40:38 UTC
>If you do not want the recently used documents to be visible, you can go to
Preferences->Interface and set Menus / Open Recent Menu Size to 0. 

This doesn't seem to work at all. I'd already tried it. Even after changing it 
to "0" documents continue to accumulate in the recent document history.

>Alternatively, you can delete the file ~/.gimp-2.0/documents when you exit.

Yes, thank you. I've already been doing this by adding it to my WindowWasher's 
list of files to clean up when I exit Windows. I just thought it might be nice 
for applications to offer in-program alternatives to deleting their own left-
over lists.

>Adding an option to clear the list of recently used documents could be 
interesting but . . . I do not expect this new feature to have
a high priority.

OK. Thanks, anyway. And thanks for a really cool application.
Comment 3 Maurits Rijk 2004-05-26 12:41:16 UTC
Setting a few target milestones now that 2.2 is coming closer.
Comment 4 Michael Natterer 2005-01-18 21:04:01 UTC
This can easily be done by copying some code from the
"Reset all tool options" stuff. Optimistically setting
to 2.4.
Comment 5 Sven Neumann 2005-02-10 14:47:56 UTC
Do we really want to have this in the Preferences or should there rather be a
"Delete document history" entry been added to the bottom of the Recently Used
file menu? And to the Images dock, of course?
Comment 6 Raphaël Quinet 2005-02-11 09:38:20 UTC
If the goal is to protect the user's privacy on shared computers (especially
for Windows users having only one account on their machine) then it would make
more sense to have an option that allows an automatic clean-up on exit as the
reporter suggested.  Requiring an explict action from the user would not be
such a big improvement over the manual deletion of the recent documents file.
So an option in the Preferences would be better (maybe in addition to an
explicit Delete entry in the appropriate places).

Recent browsers and other applications offer such an option.  I suppose that it
is very valuable for those who do not want to reveal the location of their
pr0n collection...
Comment 7 Sven Neumann 2005-06-14 12:03:27 UTC
I suggest that we just add a "Clear" button to the Document History dialog and
postpone the other change until the new recent-documents spec, that Emmanuele
Bassis is working on, is finished. (see the discussion on desktop-devel list and
http://live.gnome.org/RecentFilesAndBookmarks). That will most probably allow us
to get rid of our own document history file and will push the problem to the
desktop environment.
Comment 8 Michael Natterer 2005-06-20 19:30:31 UTC
Added the "Clear" button. Does this count as FIXED now?

2005-06-20  Michael Natterer  <mitch@gimp.org>

	* app/actions/documents-actions.c
	* app/actions/documents-commands.[ch]
	* app/widgets/gimphelp-ids.h
	* menus/documents-menu.xml: added "Clear document history" action,
	button, menu item and confirm dialog (bug #140001).
Comment 9 Sven Neumann 2005-10-19 10:12:56 UTC
I think we still need a preference option that allows to disable use of the
~/.recently-used file. That should be pretty easy to add.
Comment 10 weskaggs 2005-10-23 15:31:36 UTC
*** Bug 319466 has been marked as a duplicate of this bug. ***
Comment 11 Luis de Bethencourt Guimera 2005-10-31 00:28:46 UTC
Created attachment 54105 [details] [review]
patch for bug #140001

Here is my patch. Added a option in the preference dialog to choose to save or
not save into document history.
Comment 12 Luis de Bethencourt Guimera 2005-10-31 13:51:09 UTC
Created attachment 54128 [details] [review]
improved patch

basically the same but now you still get the list of files you have edited
during the session unti closed and using gimpcoreconfig instead of
gimpguiconfig.
Comment 13 Luis de Bethencourt Guimera 2005-10-31 13:51:20 UTC
Created attachment 54129 [details] [review]
improved patch

basically the same but now you still get the list of files you have edited
during the session unti closed and using gimpcoreconfig instead of
gimpguiconfig.
Comment 14 Michael Natterer 2005-10-31 20:29:17 UTC
Patch looks good apart from some minor stylistic issues. Will fix
them when comitting.
Comment 15 Michael Natterer 2005-10-31 20:58:03 UTC
Fixed in CVS:

2005-10-31  Michael Natterer  <mitch@gimp.org>

	Applied modified patch from Luis de Bethencourt Guimera which adds
	a "Save document history" prefs option. Fixes bug #140001.

	* app/config/gimprc-blurbs.h
	* app/config/gimpcoreconfig.[ch]: added boolean property
	"save-document-hitory".

	* app/core/gimp.c
	* app/file/file-open.c
	* app/file/file-save.c: don't save the document history and don't
	add files to the desktop-wide list of recently used files if the
	option is FALSE.

	* app/dialogs/preferences-dialog.c: added its toggle to the
	"Environment" page.
Comment 16 Michael Natterer 2005-10-31 21:30:10 UTC
Created attachment 54162 [details] [review]
actually comitted patch