After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 139723 - unref GConfClient
unref GConfClient
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Keybinding
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-04-11 14:13 UTC by Paolo Borelli
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.00 KB, patch)
2004-04-11 14:14 UTC, Paolo Borelli
none Details | Review

Description Paolo Borelli 2004-04-11 14:13:36 UTC
The GConf docs say:

________________________________________________
gconf_client_get_default()

Creates a new GConfClient using the default GConfEngine. Normally this is the
engine you want. If someone else is already using the default GConfClient, this
function returns the same one they're using, but with the reference count
incremented. So you have to unref either way.
Returns :	a new GConfClient. g_object_unref() when you're done.

________________________________________________

currently there are a couple of places where the code does:

foo_bar_func (gconf_client_get_default(), blah, blah);

so the client is not unrefed.
Comment 1 Paolo Borelli 2004-04-11 14:14:55 UTC
Created attachment 26563 [details] [review]
proposed patch
Comment 2 Jody Goldberg 2004-04-13 18:33:53 UTC
Seems reasonable.  I'll commit for 2.6.1
Comment 3 Jody Goldberg 2004-04-16 14:39:41 UTC
Apologies this slipped through the cracks as I was running the check lists.
I've committed it to HEAD, and will get it into the gnome-2-6 tree when I have
one setup.