After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 139633 - WM_DELETE_WINDOW deletes a panel w/o confirmation
WM_DELETE_WINDOW deletes a panel w/o confirmation
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
git master
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-04-10 01:50 UTC by Olaf Klischat
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: 2.8.x
GNOME version: 2.7/2.8

Attachments
Patch: Ignore the delete events. (706 bytes, patch)
2004-07-15 18:30 UTC, Sebastian Kapfer 		accepted-commit_now Details | Review

Description Olaf Klischat 2004-04-10 01:50:42 UTC 
Description of Problem:

When a panel receives a "close" command (X event
WM_DELETE_WINDOW, afaik), it gets deleted without
asking the user for confirmation.


Steps to reproduce the problem:

1. focus the panel by clicking on it or "cycling"
through the set of open windows. The panel is
focused when e.g. a dotted line appears along the
edge of a "main menu" button inside the panel.

2. Hit the keystroke defined for "close window".


Actual Results:

The panels disappears immediately without asking
the user for confirmation.

Expected Results:

The user should be asked to confirm the operation,
as is is the case if the panel is closed via
"Delete this Panel..." from the context menu.


How often does this happen? 

always


Additional Information:

According to various user reports, the following
configurations are affected by this problem:

- Gnome 2.4 / Sawfish

- Gnome 2.4 / xfwm4

- Gnome 2.6 / Sawfish


The following configurations are apparently *not*
affected:

- Gnome 2.4 / Metacity

- Gnome 2.6 / Metacity
Comment 1 Matthew Gatto 2004-04-11 09:23:05 UTC 
confirming.
Comment 2 Sebastian Kapfer 2004-07-14 17:16:36 UTC 
Same here; I'd like to add that the panel is not actually deleted. It's just
"hidden". Restarting (killall) gnome-panel makes it reappear.
Comment 3 Sebastian Kapfer 2004-07-14 17:19:00 UTC 
BTW, I don't think the panel should display a confirmation dialog when Alt+F4 is
invoked on a panel. When this happens, it is almost certainly a user mistake,
and it would be quite confusing to pop up scary dialogs. IMO gnome-panel should
just ignore this event (but prevent the deletion).
Comment 4 Sebastian Kapfer 2004-07-15 18:30:53 UTC 
Created attachment 29563 [details] [review]
Patch: Ignore the delete events.
Comment 5 Vincent Untz 2004-09-01 12:05:07 UTC 
Sounds reasonable, but is it really a show stopper for 2.8.0?
Comment 6 Sebastian Kapfer 2004-09-01 18:16:48 UTC 
It may not be a show stopper for you, but it is an unnerving bug with a trivial
fix. I don't think it needs a large amount of thinking about.
Comment 7 Vincent Untz 2004-09-02 08:40:57 UTC 
The problem is that we should have applied it before the hard code freeze. I
don't think that this bug is important enough to break the freeze for 2.8.0. But
the patch should probably be applied for 2.8.1.
Comment 8 Sebastian Kapfer 2004-09-02 10:41:10 UTC 
Sorry, I didn't know that you were frozen already.
Comment 9 Elijah Newren 2004-10-24 20:23:35 UTC 
Chris: Why did you change the Gnome Milestone from 2.8.x to 2.10.0?  Vincent
said he thought the patch should go in for 2.8.1...
Comment 10 Christian Neumair 2004-10-25 14:27:08 UTC 
Yes, sorry for that.
Comment 11 Vincent Untz 2004-10-27 09:11:13 UTC 
Comment on attachment 29563 [details] [review]
Patch: Ignore the delete events.

Please commit to gnome-2-8 branch and HEAD
Comment 12 Vincent Untz 2004-11-21 13:29:24 UTC 
I committed the patch. Thanks