After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 139587 - Crash when adding launcher
Crash when adding launcher
Status: RESOLVED FIXED
Product: quick-lounge-applet
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-04-09 14:51 UTC by Arvind S N
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch should fix the bug. (1008 bytes, patch)
2004-04-09 14:55 UTC, Arvind S N 		none Details | Review

Description Arvind S N 2004-04-09 14:51:25 UTC 
Add a new launcher from the "Properties" window without selecting any icon fot it.

We get a crash (if run with --g-fatal-warnings ) or the assertions as below.

quick-lounge-applet:9863): GdkPixbuf-CRITICAL **: file gdk-pixbuf.c: line 480
(gdk_pixbuf_get_width): assertion `pixbuf != NULL' failed

(quick-lounge-applet:9863): GdkPixbuf-CRITICAL **: file gdk-pixbuf.c: line 496
(gdk_pixbuf_get_height): assertion `pixbuf != NULL' failed

(quick-lounge-applet:9863): GdkPixbuf-CRITICAL **: file gdk-pixbuf-scale.c: line
235 (gdk_pixbuf_scale_simple): assertion `src != NULL' failed

(quick-lounge-applet:9863): GLib-GObject-CRITICAL **: file gobject.c: line 1579
(g_object_unref): assertion `G_IS_OBJECT (object)' failed


Will attach a patch in a moment.
Comment 1 Arvind S N 2004-04-09 14:55:52 UTC 
Created attachment 26528 [details] [review]
Patch should fix the bug.

The problem was when we add a launcher without selecting an icon, we had dump.

We have a check something like....

if (icon_path != NULL)
    button_load_pixbuf (button, icon_path, size);

This check caused more harm than being useful, since button_load_pixbuf () was 
anyway going to fallback to gnome-unknown.png if the icon_path was NULL.