GNOME Bugzilla – Bug 139349
Color picker should not open a new window (should use a dockable window)
Last modified: 2006-01-18 02:56:04 UTC
If you will try using color picker (o) and fill tool (shift + b) you will notice that it is a major inconvenience instead of doing this: Press o Pick color Press shift + b Click on the place you want to flood fill do this: Press o Pick color close the picker window (you cant select another tool without activating the image window) press shift + b fill the area
This bug could be summarized like this: Color picker should not open a new window. This is what causes the problem because the new window that pops up after picking a color steals the focus from the image window. The fact that the new window pops up in front of the image window (depending on your preferences and WM setup) only makes things worse, but the basic problem is that a new window is created. It would be nicer if the color picker (and other tools: crop, transform and text) would use or re-use a dialog window that could be placed in a dock instead of popping up a new window every time.
Am I missing something or would this be automatically fixed after bug #119878 is fixed? In the title it mentions "all docks" and later "all windows". If it applies to all windows this wouldn't be a problem.
Yes, the fix for bug #119878 should get around this problem nicely. Since the window is session managed, it also does not get into the way so I think it's not necessary to get rid of it. What would be nice would be to add the Ctrl-picks-color feature available for the paint tool to the bucket-fill tool. But then the bucket-fill tool already uses all modifiers.
Yes fixing bug #119878 would solve my problem, yet being able to dock windows like color picker and other tools would be nice anyway. Or at least checking whether the Color picker window is still opend and can be refreshed without geting focused.
Created attachment 26505 [details] Tga gimp can't load It has no alpha channel, is RLE compressed, black and white (RGB)
This attachment should have gone to bug 139343, right?
oh sorry :( mozill'as history tricked me while pasting.
Is there a way to move or remove the attachment ?
Don't worry about the attachment: we will just ignore it. I changed the summary of the bug report and added a mention about the fact that the window should be dockable. So even if bug #119878 is eventually fixed when we start using GTK+ 2.4, we can keep this open as a separate enhancement.
As a quick fix, we should probably replace the call to gtk_window_present() with gtk_window_show().
I've committed the following simple fix to both branches: 2004-04-16 Sven Neumann <sven@gimp.org> * app/tools/gimpcolorpickertool.c * app/tools/gimpmeasuretool.c: don't use gtk_window_present() to raise the tool dialog since it also moves the focus away from the image window. Fixes the problem described in bug #139349. IMO we can close this report as FIXED now but since the focus moved away from the original bug-report to other things, perhaps it should be kept open. I am undecided...
Oh well, it doesn't really fix the problem, it only makes it less worse. So we better keep this report open.
Just a note that bug #119878, which supposedly was going to solve this problem automatically once fixed, is now supposedly fixed, but the problem still exists.
Has there been any progress on this bug? And yes, it is a bug. The color picker shouldn't pop up a dialog. Its extremely frustrating to the workflow. If a person wants to know what color they've just selected, they could just as easily double click on the color, once its selected. I've used the GIMP for years, and this "feature" has annoyed me since 1.3ish. For pixel art, where you are constantly selecting new colors, this cuts your productivity way down. In fact, its the sole reason that I don't use GIMP exclusively for pixelling. If this was fixed, I could use GIMP for all my image needs.
I don't know exactly when, but this enhancement request has been solved in gimp CVS, now the color picker no longer opens up a dialog unless requested by the user. It is not exactly a dockable window shared between tools, but the usability problem is resolved. Ben: See my reply to your mail to gimp-user.