After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 139124 - set home page to current page dialog gets wrong page
set home page to current page dialog gets wrong page
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Preferences
unspecified
Other Linux
: Normal minor
: 1.4
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2004-04-05 10:30 UTC by Mikel Ward
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
proposed fix (3.59 KB, patch)
2004-04-05 12:15 UTC, Christian Persch 		none Details | Review
alternative fix (4.07 KB, patch)
2004-04-05 17:47 UTC, Christian Persch 		none Details | Review

Description Mikel Ward 2004-04-05 10:30:30 UTC 
1. Open a new window, open a new tab within that window, go to a page (page A)
2. Open a new window, open a new tab within that window, go to a page (page B)
3. Menu->Edit->Preferences->General
4. Click "Set to Current Page"

Actual:
Address is set to page A (the current page in the inactive window)

Expected:
Address is set to page B (the current page in the active window)
Comment 1 Christian Persch 2004-04-05 11:18:33 UTC 
Happens with 1.2.x too.

Fixing this would involve making ephy_session_get_active_window() really do
that, by having the session track the active window (focus in/out events).
Comment 2 Christian Persch 2004-04-05 12:15:43 UTC 
Created attachment 26353 [details] [review]
proposed fix

The patch uses the focus-in-event on EphyWindow:s to keep track of the active
window. I've also implemented a ::active-window property for EphySession, so
that extensions have easy access to focus changes (iirc the dashboard extension
wanted to do something like that).

Marco, can you review?
Comment 3 Christian Persch 2004-04-05 17:47:28 UTC 
Created attachment 26366 [details] [review]
alternative fix
Comment 4 Christian Persch 2004-04-05 17:53:47 UTC 
Fixed on HEAD and gnome-2-6 branch.