After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 139035 - Non-standard regex used as libtool argument
Non-standard regex used as libtool argument
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other other
: Normal critical
: 0.8.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-04-04 14:38 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample patch (662 bytes, patch)
2004-04-04 14:39 UTC, Julio Merino
none Details | Review

Description Julio Merino 2004-04-04 14:38:58 UTC
The configure script in gst-plugin defines some standard arguments for libtool
(in the GST_PLUGIN_LDFLAGS variable), used to build all plugins.  One of these
arguments is -export-symbols-regex, used to determine which symbols should be
made public from the plugin.

The problem is that the regex used, which is parsed internally by libtool using
egrep, is not recognized by NetBSD's native grep(1) utility.  The neat result of
this is that _no_ symbols are exported from plugins.

The regex contains {gst_,Gst,GST_}, which is the block not recognized by grep
(it is beeing treated as a simple literal string).  As an example (using the
whole regex):

[dawn jmmv] $ echo '{gst_,Gst,GST_}foobar' | grep '[_]*{gst_,Gst,GST_}.*'
{gst_,Gst,GST_}foobar
[dawn jmmv] $ echo 'gst_' | grep '[_]*{gst_,Gst,GST_}.*'
[dawn jmmv] $

I've fixed it by changing the regex to '[_]*(gst_|Gst|GST_).*'.  Patch attached
for this.

[dawn jmmv] $ echo 'gst_foobar' | grep -E '[_]*(gst_|Gst|GST_).*'
gst_foobar
Comment 1 Julio Merino 2004-04-04 14:39:39 UTC
Created attachment 26313 [details] [review]
Sample patch
Comment 2 Benjamin Otte (Company) 2004-04-04 23:35:22 UTC
yeah, my regex-fu is not portable yet.

I fixed it in gst-plugins and gst-ffmpeg