GNOME Bugzilla – Bug 138731
Desktop font cannot be gettextixed.
Last modified: 2005-05-12 15:23:36 UTC
Description of Problem: Desktop font is 'Sans 10' by default and it cannot be gettextized. Steps to reproduce the problem: 1. Invoke 'intltool-update --pot' in nautilus/po. Actual Results: Cannot derive the string 'Sans 10' from libnautilus-private/apps_nautilus_preferences.schemas.in and localize the default font. Expected Results: Update .po file and merge apps_nautilus_preferences.schemas with apps_nautilus_preferences.schemas.in and .po files. How often does this happen? When need localize nautilus. Additional Information: I attached the patch.
Created attachment 26197 [details] [review] patch for apps_nautilus_preferences.schemas.in
Comment on attachment 26197 [details] [review] patch for apps_nautilus_preferences.schemas.in Looks ok to me, although it breaks i18n freeze. Go ahead and commit this after we branch, or if you want to get release-team and i18n team approval for it, go for it.
Please add a verbose comment above the string before committing the patch. regs, Chris
Originally this patch is needed by the issue that the default font size is too large on a locale. The font size should be handled by locale and schemas.in has the logic. If the patch is not applied, when invoke 'intltool-update $locale' in $nautilus_dir/po, ${locale}.po cannot be added 'Sans 10' at the msgid. So whenever invoke 'make apps_nautilus_preferences.schemas' in $nautilus_dir/libnautilus-private, cannot configure the default size by locale. If the patdh is applied, when add the path of libnautilus-private/apps_nautilus_preferences.schemas in $nautilus_dir/POTFILES.in and invoke 'intltool-update $locale', then the msgid 'Sans 10' is added into ${locale}.po. So we can change the default font size by locale in po files. After the modifications are complited, when invoke 'make apps_nautilus_preferences.schemas' in $nautilus_dir/libnautilus-private, we can configure the default size by locale.
Comment on attachment 26197 [details] [review] patch for apps_nautilus_preferences.schemas.in You misunderstood me :D. I totally knew how it worked, I just wanted you to add a translator comment above the string that is extracted by gettext. BTW: You can commit this patch to nautilus HEAD as it isn't string frozen :). regs, Chris
Created attachment 30460 [details] [review] patch for apps_nautilus_preferences.schemas.in Sorry for my late response and misunderstandings. I updated the patch with comments. Please review it. I don't have the right to commit patches so could you put back it instead of me?
Why do translations need to change the default desktop font?
Sans is a virtual so the actual used font is different between locales. The appearance is different per font so some locale wants to samll fonts by default and other locales keep the defualt size, then the better solution is to provide to customize font names and font sizes by lcoale.
Committed on HEAD - Thanks.
This change isn't liked by some translators, and seems to lead to inconsistently looking desktops. See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=154185 for some details. It seems the original reason for this was to change the font size. Maybe we should just translate the font size?
Created attachment 46336 [details] [review] Proposed patch to revert localisation of font name and change translator comment Here is a patch. OK to commit on HEAD and gnome-2.10 branch? As noted in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=154185 this patch also fixes the gu locale.
Looks good to me. Please commit.
Hi. I've committed the patch in comment 11 to HEAD and something similar to the gnome-2-10 branch.