GNOME Bugzilla – Bug 138595
Task up and down should work on selections.
Last modified: 2004-12-22 21:47:04 UTC
Select a task selection. Click up or down. Only the 1 task moves. Not happy. Need ALL selected tasks to move up or down. *note: I've already patched this so this can be closed once the patch is in CVS. Rgds, Lincoln.
Created attachment 26384 [details] [review] This adds this new feature. Attached is a standalone patch that allows you to select a range of tasks and do a move up and move down within gantt and task view. A very handy feature when rearranging your schedule Before only individual tasks could be moved which meant that shifting your task schedule design could be tedious. It handles all sane selections including ctrl-clicking a discountinuous list of tasks (which would be a weird thing to do in practice but it works anyway). Rgds, Lincoln.
Created attachment 26385 [details] [review] Same as before but with g_list_free(list) Ha ha... guess what ? - just noticed that there was no g_list_free(list) at the end of either the planner_task_tree_move_task_up() or planner_task_tree_move_task_down() so those have potentially been leaking since MrProject. Attached is version 2 with the required g_list_free(list); !! Rgds, Lincoln.
Created attachment 26422 [details] [review] Same as before but with formatting changes and for planner-task-tree.c v1.15 I use anon CVS so previous patch was out of date (now v1.15 of planner-task-tree.c was v1.14). Also used cvs diff -uBp not -ubBp so that the 'b' flag is not used so that indenting gets passed across correctly and also simplified code a little by removing temptask.
Committed, but there are a few details left to take care of, I think. I added FIXME comments to the code.
Created attachment 26477 [details] [review] The committed patch
Created attachment 26674 [details] [review] Extra tweak to fix task down problem. Apply on top of the current CVS patch. Task down didn't work right :) Now it does. May not catch all cases but it works for the expected cases.
Fixed in CVS (might want to open a new bug for the FIXME, but it's not critical).