GNOME Bugzilla – Bug 138346
gnome_font_face_is_italic always return FALSE
Last modified: 2004-12-22 21:47:04 UTC
Any attempt to know if a font is italic or oblique fails
Created attachment 26029 [details] [review] Should fix the problem (not tested)
The code in cvs is obviously wrong, but I am not sure whether it is a good idea to test equality of a floating point number against zero. Shouldn't we use < and/or >? SInce the floating point numer 0.0 could be represented with a bit pattern that is not completely 0 I wold also prefer an explicit comparison.
GPEntry::italic_angle is an integer, not a double. So there is no floating point number there.
Adding PATCH keyword.
fixed with a similar patch. Technically only negative values for italic_angle indicate an italic font.