After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 138346 - gnome_font_face_is_italic always return FALSE
gnome_font_face_is_italic always return FALSE
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: fonts
unspecified
Other Linux
: High normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-03-28 16:33 UTC by Jean Bréfort
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Should fix the problem (not tested) (119 bytes, patch)
2004-03-28 16:34 UTC, Jean Bréfort
none Details | Review

Description Jean Bréfort 2004-03-28 16:33:44 UTC
Any attempt to know if a font is italic or oblique fails
Comment 1 Jean Bréfort 2004-03-28 16:34:53 UTC
Created attachment 26029 [details] [review]
Should fix the problem (not tested)
Comment 2 Andreas J. Guelzow 2004-03-28 16:49:43 UTC
The code in cvs is obviously wrong, but I am not sure whether it is a good idea
to test equality of a floating point number against zero. Shouldn't we use <
and/or >?

SInce the floating point numer 0.0 could be represented with a bit pattern that
is not completely 0 I wold also prefer an explicit comparison.  
Comment 3 Jean Bréfort 2004-03-28 19:01:52 UTC
GPEntry::italic_angle is an integer, not a double. So there is no floating point
number there.
Comment 4 Michael Terry 2004-03-29 16:50:37 UTC
Adding PATCH keyword.
Comment 5 Andreas J. Guelzow 2004-04-06 06:03:20 UTC
fixed with a similar patch. Technically only negative values for italic_angle
indicate an italic font.